-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum version of susieR? #41
Comments
Hi @jdblischak, thanks so much for catching this and giving the detailed explanation. I think it's probably best to just make 0.9.0 the minimum required version, esp it simplifies things when checking for required/suggested columns. I've just specified this in the DESCRIPTION: ...
snpStats,
susieR (>= 0.9.0)
Remotes:
github::stephenslab/susieR
... Now in the dev branch and will merge after some other fixes. |
Sounds good. Thanks! Also FYI that last week I created conda binaires for susieR 0.9.0 for anyone that wants to install susieR via conda. |
That's amazing, @jdblischak ! I'll add it to the echoR conda yaml. |
@jdblischak I also just came across this implementation of susieR. Not sure how different it is from yours but it seems to have have (dev?) versions 0.9.0 and 0.10.0 |
Those conda binaries were created by Abhishek, a postdoc in the Stephens lab. He built them directly off the master branch, which is presumably why he added "dev" to the version. https://github.com/aksarkar/my-conda-recipes/blob/master/r-susier/meta.yaml I was going to request that they tag/release a more recent version of susieR on GitHub, but in the meantime, they submitted susieR to CRAN. So I added it to conda-forge. See PR #48 |
In the past I was able to use susieR 0.8.0 with the vignette example, but now I no longer can. I started trying to fix this, but realized this may not be worth the effort since 0.9.0 has already been released and the latest development version is 0.10.1.
There is currently code to choose between
susie_bhat()
andsusie_suff_stat()
:echolocatoR/R/SUSIE.R
Lines 134 to 143 in b055ac0
This didn't work for me.
find("susie_bhat")
fails to find the function in susieR 0.8.0, and then the function fails when it tries toget()
the non-existentsusie_suff_stat()
. I fixed this issue in this commit on my fork, but then I got another error:susie_suff_stat()
has the argumentmaf
, butsusie_bhat()
andsusie_ss()
don't:What are your thoughts? Do you want to try to fix this to support susieR 0.8.0, or require a minimum of 0.9.0?
The text was updated successfully, but these errors were encountered: