OHRM-941:Integrate Doctrine 2.6 for i18n related entities #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->leftJoin('t.I18NLangString ls') | ||
| ->leftJoin('t.I18NLanguage l') | ||
| ->andWhere('l.code = ?', $langCode); | ||
| $q = Doctrine2::getEntityManager()->getRepository(I18NTranslate::class)->createQueryBuilder('t'); |
There was a problem hiding this comment.
This part may be abstract to DAO class .. something like $this->getQueryBuilder()
| * @throws DaoException | ||
| */ | ||
| public function getLanguageByCode(string $langCode) | ||
| { | ||
| try { | ||
| return Doctrine::getTable('I18NLanguage')->findOneBy('code', $langCode); | ||
| return Doctrine2::getEntityManager()->getRepository(I18NLanguage::class)->findOneBy(['code' => $langCode]); |
There was a problem hiding this comment.
reuse $this->queryBuilder here
|
|
||
| if (!empty($searchParams->getParameter('langCode'))) { | ||
| $q->andWhere('l.code = ?', $searchParams->getParameter('langCode')); | ||
| $q->andWhere('l.code = :langCode'); |
There was a problem hiding this comment.
This is good, binding param with a name
| * @throws DaoException | ||
| */ | ||
| public function getI18NSource(string $source) | ||
| { | ||
| try { | ||
| return Doctrine::getTable('I18NSource')->findOneBy('source', $source); | ||
| return Doctrine2::getEntityManager()->getRepository(I18NSource::class)->findOneBy(['source' => $source]); |
There was a problem hiding this comment.
what if use orangehrm/orm class that wraps doctrine stuff ?
| @@ -272,7 +279,8 @@ public function saveI18NTranslate(I18NTranslate $i18NTranslate) | |||
| */ | |||
| public function saveI18NLanguage(I18NLanguage $i18NLanguage) | |||
| { | |||
| $i18NLanguage->save(); | |||
| Doctrine2::getEntityManager()->persist($i18NLanguage); | |||
There was a problem hiding this comment.
Doctrine2 may replace oranghrm/orm:getEntityManager()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.