Attempt to wrap orm exception to increase code coverage #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OHRM-945:Intiate Vue 3.x project with OXD components * OHRM-1007:Initiate Symfony 4.x * OHRM-1007:Update to symfony 4.x stack * OHRM-1009:Add github action for Vue app linting * OHRM-1011:Develop Add Job Title page * OHRM-1022:Develop Job Titles list page * OHRM-1063:Develop job category API endpoint * OHRM-1062:Remove Vue default entrypoint
* vue config updated pages json added * new line added
* axios added * admin job category missing routes added * job category list and new form added * job title lint fixes * yarn lock fix oxd * updated oxd-button props * Job category edit and update component added * delete confirmation dialog moved to client dir * oxd styles imported * job category single prop types added * newline added * pages command removed * moved old vues, new build process, OS header added * OS code header added * paginate function added * job title remove fetch, prop types added * axios wrapper fixes
* OHRM5X-7:Intitate base vue controller * OHRM5X-12:Develop base vue twig layout
* OHRM5X-17:Develop pim/employees endpoint * OHRM5X-17:Added filter fields to users API
* organization structure page added * fixup! organization structure page added * organization structure page added * organization structure page added * org structure api connected * fixup! org structure api connected * fixup! org structure api connected * fixup! org structure api connected
* oxd-datatable improvements implemented * fixup! oxd-datatable improvements implemented
* Qualification skills UI added * OHRM5X-65: skills API * OHRM5X-65: Skills DAO and Service test * OHRM5X-65: entities updated * OHRM5X-65: fixed github issues * OHRM5X-65: code refactoring * OHRM5X-98: connect skils screen to API * OHRM5X-65: fixed minor issues * OHRM5X-65: Skill API validation * OHRM5X-65: fixed minorissues * OHRM5X-98: skill creen changes * OHRM5X-65: updated entities * OHRM5X-65: revert auth routes file * OHRM5X-65: entity relationship updates * OHRM5X-65: entity finalized and fixed minor issues * OHRM5X-65: fixed conflicts * OHRM5X-65: fixed unit test issue * OHRM5X-65: validation char limit Co-authored-by: Chamara Abesinghe <chamara@orangehrmlive.com>
* OHRM5X-319: PIM - Employee Termination screens * fixup! OHRM5X-319: PIM - Employee Termination screens * OHRM5X-319:Implement termination reasons & active employee * OHRM5X-319: PIM - Employee Termination API connect Co-authored-by: Rajitha Kumara <tmrkumara.15@cse.mrt.ac.lk>
* OHRM5X-83:Trim username when username validation * OHRM5X-264:Fix attachment length validation issue * OHRM5X-81:Fix user screen username filter issue * OHRM5X-88:Improve password not match issue in add user * OHRM5X-223:Fix employee list filter using empNumber * OHRM5X-82:Define undeletable users & refactor user API
…ils and Contact Details (orangehrm#811) * bug fixes * validation rules added * minor change * add validation rules * fix validation rule isssue
* OHRM5X-329: CSV file support added * OHRM5X-331: file uploader added to edit job title * OHRM5X-93: password field autocomplete off added * OHRM5X-87: Job category edit UI, loading state fix
* OHRM5X-146:Refactor text helper * OHRM5X-146:Improve session timeout redirection * OHRM5X-146:Change default homepage to pim default home * OHRM5X-305:Fix sorting issue in pay frequency list * OHRM5X-308:Fix salary comment field length validation * OHRM5X-263:Make attachment size into human readable string * OHRM5X-311:Fix subunit deletion issue & employee job titles dropdown
* OHRM5X-173:Handle login errors through session flash messages * OHRM5X-173:Add unit tests for authentication service * OHRM5X-174:Add login error messages * OHRM5X-269:Add node scripts to cypress testing * OHRM5X-146:Update axios interceptor to handle unauthorized requests * OHRM5X-146:Add unit tests for url helper * OHRM5X-339:Add missing required asterisk to termination modal * OHRM5X-349:Fix user sessions clashed when two instances access using same browser * OHRM5X-314:Fix edit salary component validations * OHRM5X-299:Add date validation for employee contract * OHRM5X-299:Add unit test for endDateShouldBeAfterStartDate validation rule
…rm#825) * OHRM5X-68:Remove module directories from plugins * OHRM5X-352:Fix work expirenece broken issue * OHRM5X-342:Align all action columns in qualifications screen
* OHRM5X-217: PIM Employee list sorting implemented * OHRM5X-254: PIM Emg. contact disable table feature * OHRM5X-250:Disable employee dependents table action conditionally * OHRM5X-313:Disable employee salary table action conditionally * OHRM5X-82: Admin - prevent delete admin user * OHRM5X-295: PIM job contract toggle state bug fix * OHRM5X-359:PIM qualification disable table feature Co-authored-by: Rajitha Kumara <rajitha@orangehrm.us.com>
* OHRM5X-107: Develop pim optional fields config screen * OHRM5X-107: PIM - Optional Fields Responsive fixes Co-authored-by: Chamara Abesinghe <chamara@orangehrmlive.com>
…#786) * Test scripts for job employment status screen * updated test scripts for employment status * updated test scripts for employment status * OHRM5X-270: Completed Employment status screen * OHRM5X - 270 updated employment status screen * OHRM5X-270 Employment status updated test scripts
* OHRM5X-108: Custom fields added ADD button conditionally * OHRM5X-383: Card table height fixes Co-authored-by: Chamara Abesinghe <chamara@orangehrmlive.com>
* OHRM5X-357: employee autocomplete added * OHRM5X-357: emp list filters updated to oxd-select * OHRM5X-357:user list filters updated to oxd-select
| } catch (Exception $e) { | ||
| throw new DaoException($e->getMessage()); | ||
| } | ||
| return $this->wrapException( |
There was a problem hiding this comment.
I don't think this is right way to handle the exception
| { | ||
| try { | ||
| return $closure(); | ||
| } catch (NotNullConstraintViolationException $e) { |
There was a problem hiding this comment.
Basically, we shouldn't catch exceptions in DAO and throw other exceptions
|
@RajithaKumara don't hack exceptions to improve code coverage , this is fundamentally wrong |
RajithaKumara
force-pushed
the
5.0
branch
2 times, most recently
from
c6d3502
to
2ace9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.