Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused types #781

Closed
Rakambda opened this issue May 21, 2024 · 0 comments · Fixed by #782
Closed

Remove unused types #781

Rakambda opened this issue May 21, 2024 · 0 comments · Fixed by #782
Assignees
@Rakambda
Labels
app: ⛏️ miner type: 🧱 enhancement New feature or request

Comments

@Rakambda
Copy link
Member

Description

Currently messages are parsed almost fully, and same for types, if an unknown one appears, it'll crash saying it's unknown.

This is nice at first to explore the possibilities of the API but has now become a burden to maintain and doesn't make much sense. We should make jackson ignore what it doesn't know and not throw exceptions when something we don't care about is off.
@Rakambda Rakambda self-assigned this May 21, 2024
@Rakambda Rakambda linked a pull request May 21, 2024 that will close this issue
Only parse used data to reduce errors when API changes #782
Merged
2 tasks
Rakambda added a commit that referenced this issue May 22, 2024
@Rakambda
Merge branch 'develop' into feat/gh-781
23a97ff
Rakambda added a commit that referenced this issue Jun 9, 2024
@Rakambda
Merge remote-tracking branch 'origin/develop' into feat/gh-781
4838480 
# Conflicts:
#	miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/gql/gql/data/types/DropCampaign.java
#	miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/gql/gql/data/types/GQLType.java
#	miner/src/test/java/fr/rakambda/channelpointsminer/miner/priority/DropsPriorityTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rakambda Rakambda

Labels
app: ⛏️ miner type: 🧱 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only parse used data to reduce errors when API changes RakambdaOrg/ChannelPointsMiner
1 participant
@Rakambda