Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only parse used data to reduce errors when API changes #782

Merged
merged 5 commits into from
Jun 9, 2024

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

Internal change

Description

@Rakambda Rakambda self-assigned this May 21, 2024
@Rakambda Rakambda requested a review from couchoud-t as a code owner May 21, 2024 14:54
@Rakambda Rakambda linked an issue May 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (fe011c2) to head (d890138).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #782      +/-   ##
=============================================
+ Coverage      85.35%   85.68%   +0.33%     
+ Complexity      1108     1107       -1     
=============================================
  Files            204      200       -4     
  Lines           3483     3466      -17     
  Branches         271      271              
=============================================
- Hits            2973     2970       -3     
+ Misses           456      442      -14     
  Partials          54       54              
Flag Coverage Δ
unittests-miner 86.07% <ø> (+0.33%) ⬆️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/gql/gql/data/types/DropCampaign.java
#	miner/src/main/java/fr/rakambda/channelpointsminer/miner/api/gql/gql/data/types/GQLType.java
#	miner/src/test/java/fr/rakambda/channelpointsminer/miner/priority/DropsPriorityTest.java
@Rakambda Rakambda merged commit 89f79d2 into develop Jun 9, 2024
12 checks passed
@Rakambda Rakambda deleted the feat/gh-781 branch June 9, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused types
1 participant