Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Toggle Button-2 #1040

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Added Toggle Button-2 #1040

merged 7 commits into from
Jun 26, 2024

Conversation

Vikashchou-dhary
Copy link
Contributor

@Vikashchou-dhary Vikashchou-dhary commented Jun 16, 2024

Fixes Issue🛠️

Closes #899

Description👨‍💻

I have added the toggle button for dark/light background theme.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

light mode

dark mode

I have added the toogle button for dark/light background theme;
Copy link

netlify bot commented Jun 16, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit aaef8a9
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/667c1937f239a300080e0a67
😎 Deploy Preview https://deploy-preview-1040--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Vikashchou-dhary, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

Why have you added your component in backgrounds if it is a toggle button @Vikashchou-dhary

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 20, 2024
@Vikashchou-dhary
Copy link
Contributor Author

although it is a button but as it is used to change the background color so i added in the background category

@Vikashchou-dhary
Copy link
Contributor Author

Vikashchou-dhary commented Jun 23, 2024

@Rakesh9100 if it does not align with the background section than I request that the toggle button which I have requested to merge has better UX than the toggle button in button section so I request to merge it in place of toggle button in the button section

@Rakesh9100 Rakesh9100 changed the title #899 completed Added Toggle Button-2 Jun 25, 2024
@Rakesh9100
Copy link
Owner

  1. Rename your folder to Toggle-Button-2 and make the necessary changes in this same PR.
  2. Attach the screenshots of your work.
  3. Also, add your button part in the buttons.html file to display on the website @Vikashchou-dhary

Made necessary changes as per mentioned
@Vikashchou-dhary
Copy link
Contributor Author

toggle 2
light mode
dark mode

@Rakesh9100 Rakesh9100 merged commit eb071f2 into Rakesh9100:main Jun 26, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @Vikashchou-dhary

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points and removed question 🤔 Further information is requested labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level2 GSSoC2k24 Level-2 Task -- 25 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Toggle Button-2
2 participants