Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the scroll to top icon for small devices #839

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

sharmi4590
Copy link
Contributor

@sharmi4590 sharmi4590 commented May 30, 2024

Fixes Issue🛠️

Closes #772

Description👨‍💻

I made the icon visible for mobile screens (I replaced fontawsome with bootstrap icon beacause fontawesome does not support mobile display), and removed the collision between chat icon and top arrow icon.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Before

image

After

Screenshot (495)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sharmi4590, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 30, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 1f17fbe
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/6662230afd55eb0008cb1bd0
😎 Deploy Preview https://deploy-preview-839--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title Icons visibility and removing overlapping Fixed the scroll to top icon for small devices May 30, 2024
@Rakesh9100
Copy link
Owner

Pls do change for every components category pages as well @sharmi4590

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 30, 2024
@sharmi4590
Copy link
Contributor Author

@Rakesh9100 Changed for every component category.

@Rakesh9100 Rakesh9100 merged commit 4814ee5 into Rakesh9100:main Jun 6, 2024
4 checks passed
Copy link

github-actions bot commented Jun 6, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @sharmi4590

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points and removed question 🤔 Further information is requested labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the scroll to top icon for small devices
2 participants