Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displayed No results found message #1015

Merged
merged 20 commits into from
May 31, 2024
Merged

Conversation

Janani-m17
Copy link
Contributor

@Janani-m17 Janani-m17 commented May 31, 2024

Fixes Issue🛠️

Closes #816

Description👨‍💻

If the user searches the calculator that is not available in the calcdiverse It should display No Results Found.

Type of change📄

Added changes in index.html

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Yes I have tested the application.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

@Rakesh9100

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Janani-m17, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 31, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 65aa926
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665a0d285c1e0c0008a26273
😎 Deploy Preview https://deploy-preview-1015--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title Added feature to display No Results found Displayed No results found message May 31, 2024
@Rakesh9100
Copy link
Owner

https://deploy-preview-1015--calcdiverse.netlify.app/

When I am checking the deploy preview and testing your changes, No results found message is not coming @Janani-m17

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 31, 2024
@Janani-m17
Copy link
Contributor Author

Janani-m17 commented May 31, 2024

@Rakesh9100 Rakesh9100 merged commit f964bea into Rakesh9100:main May 31, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Merged 🙌 @Janani-m17

@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label May 31, 2024
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points labels May 31, 2024
@Janani-m17
Copy link
Contributor Author

@Rakesh9100 Thank you sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSoC 2k24 Open Source Program level1 GSSoC2k24 Level-1 Task -- 10 Points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Display No results found message
2 participants