Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifted the search bar at the top #1439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Utsavladia
Copy link

@Utsavladia Utsavladia commented Jun 25, 2024

Fixes Issue🛠️

Closes #1347

Description👨‍💻

Shifted the search bar in the navbar.

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Utsavladia, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 9edb191
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/667a8ff7d618700008ab0e10
😎 Deploy Preview https://deploy-preview-1439--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Nihal4777
Copy link

@Rakesh9100 This PR can be merged.

@Rakesh9100 Rakesh9100 changed the title Shifted searchbar and made responsive Shifted the search bar at the top Jun 27, 2024
@Rakesh9100
Copy link
Owner

It is not at all responsive, navbar responsiveness is lost @Utsavladia

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 27, 2024
@Utsavladia
Copy link
Author

@Rakesh9100
I tried to make it responsive for all sizes but because of many things in the navbar there is a lack of space so all cannot be fitted with space...
we can add the new navbar below the current one specially for search bar or
we can have all the option as dropdown like youtube only the large search bar as the main component in the navbar...

What ever you wish i can change into that...
or suggest me if you have any other idea...

@Rakesh9100
Copy link
Owner

we can have all the option as dropdown like youtube only the large search bar as the main component in the navbar...

We can go with this, but how and where all other options of navbar will be present @Utsavladia

@Utsavladia
Copy link
Author

we can have all the option as dropdown like youtube only the large search bar as the main component in the navbar...

We can go with this, but how and where all other options of navbar will be present @Utsavladia

In case of large search bar as main component and all options of navbar in dropdown... The drop-down same as mobile screen view...

In case of separate navbar for search bar component we can have a new navbar below the current one that will contain only the search bar

@Rakesh9100
Copy link
Owner

Provide any supporting screenshots you have implemented on any website on how it will look after your changes @Utsavladia

@Utsavladia
Copy link
Author

@Rakesh9100
Like this a separate navbar for search

image

@Rakesh9100
Copy link
Owner

Okay, we can do this but the home page design should not be disturbed @Utsavladia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question 🤔 Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Shift the search bar at the top
3 participants