Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test 'not regenerate all subindexes' doesn't actually test that #150

Closed
softmoth opened this issue Apr 13, 2021 · 3 comments
Closed

test 'not regenerate all subindexes' doesn't actually test that #150

softmoth opened this issue Apr 13, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@softmoth
Copy link
Contributor

The test case 'not regenerate all subindexes' in t/102-update.t does not verify that unused subindexes are not regenerated.

  1. Looking at line 52, it saves timestamps only for the subindexes that will be changed.
  2. At line 64, it verifies that all of the changed subindexes have a newer timestamp.
  3. At no place does it verify that the other subindexes have the original timestamp.
@softmoth softmoth added the bug Something isn't working label Apr 13, 2021
@JJ
Copy link
Contributor

JJ commented Apr 13, 2021

🤔

@JJ JJ assigned JJ and unassigned antoniogamiz Apr 13, 2021
@JJ
Copy link
Contributor

JJ commented Apr 14, 2021

Well, it's updating everything. I'm starting to think that the problem is that's it's actually testing changes since the script was started, which means it changed everything, instead of just the two files that were altered. But I'm not totally sure about that, and generating the cache all over takes time.

@JJ
Copy link
Contributor

JJ commented Apr 14, 2021

I drilled it down to list-files from Pod::From::Cache returning all files instead of only modified files. I really have no idea why this happens, and it does not seem to be an actual problem otherwise. Must be the test environment...

JJ added a commit that referenced this issue Apr 16, 2021
JJ added a commit that referenced this issue Apr 16, 2021
Which checks that, effectively, everything seems to be changing at the same time...
JJ added a commit that referenced this issue Apr 16, 2021
Which pass when finanalyst/raku-pod-from-cache#10 is solved with its issue merged.
JJ added a commit that referenced this issue Apr 16, 2021
Still to go the actual checking that there are some things that don't change.
@JJ JJ closed this as completed in e026d44 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants