-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General comments #37
Comments
Thanks, Tom. We'll look into it.
|
So the first two points says that we need two different directories. Once for default config and another for the user config. Where do you propose I create these directories? In the root directory? The user config dir does not have any problem, but the default should be inside resources dir because it needs to be used by the tests. I like the idea about JSON::Hjson. In fact, I was having some troubles documenting the config file because I could not use comments. Thanks for the recommendation :). |
I think having the default config info in the resources directory is okay, but, since it's default, it could be copied to a new dir on setup, and deleted upon clean, could it not? My concern was that it's not so obvious where the default config is. But I guess I could live with it as is. In like manner, I would have the user-config dir created on setup it it doesn't exist. And possibly just copy the default json into it at the same time. |
Currently "Documentable" is not providing the config.json file, and possibly some other resources. I suggest, at least for Linux, we look for another solution instead of the wget and curl which rely on "external" resources. One possibility: Use the "resources" directory and the META6.json so the resources get installed along with oher components. In addition, use the "hooks" directory to provide Perl executables to install the resources in a well-known directory like "/usr/share/raku/documentable/resources" (or, for a non-root user, in, say, the "$HOME/.raku/docmental/resources" directory). When "docmentable setup" is run it would copy the default config.json into the "config-local" directory, and other assets into the local doc repo in the appropriate directory. The user could, optionally, create a "config-user" directory for customizing the confg to his own requirements. I will try to create a PR to demo this when I get the time (as well as clean up the text in this stream of consciousness). |
El mar., 17 sept. 2019 a las 19:13, Tom Browder (<notifications@github.com>)
escribió:
Currently "Documentable" is not providing the config.json file, and
possibly some other resources. I suggest, at least for Linux, we look for
another solution instead of the wget and curl which rely on "external"
resources.
Actually, in the case of the docs we are providing it via the repo itself.
But you are right, this is less than awesome.
I will try to create a PR to demo this when I get the time (as well as
clean up the text in this stream of consciousness).
Thanks!
|
After some success, and then a set back, I stepped back and started with a clean slate to try to see the big picture. In an empty directory I executed:
After all that I was able to see the different states and their directory structures. And that has helped me to see better how to proceed. Some fresh conclusions:
plus, of course, all the other directories in our doc model. The only added directory that would be special would be the config-user directory which wouldn't be touched by setup but it would be used by documentable if it exists. |
There's the mini-doc repo to that kind of things. You can improve it adding
more test cases...
|
Hi,
I'm still alive! Sorry for not being active lately. I'm trying to setup my
new internet connection (there are several problems I hope to resolve this
week). I have also started a new course at the University so I'm kind of
buddy.
Thanks for your work @tbrowder, I will implement it ASAP.
El sáb., 21 sept. 2019 10:20, Juan Julián Merelo Guervós <
notifications@github.com> escribió:
… There's the mini-doc repo to that kind of things. You can improve it adding
more test cases...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#37>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPOARZVS47BXJWNUJQCMX3QKXKLZANCNFSM4ITAPMPQ>
.
|
@JJ and @antoniogamiz, don't listen to my babbling too much, but I am still learning @antoniogamiz's strategy which looks better the more I look at it. The thoughts I put down yesterday are mostly wrongish, but I have more hope for today's direction. I think the main problem is the disconnect between the Documentable file tree and the using doc repo layout. I plan to try a slightly different tack today back toward a slightly different layout. Good luck to both of you for the new school year! |
Thanks! What do you mean by "Documentable file tree and the using doc repo
layout"? Documentable only needs a root dir and the name of the
subdirectories to work. By default, it looks for "Language Types Native
Programs", but it can be configured using the CLI.
El sáb., 21 sept. 2019 13:29, Tom Browder <notifications@github.com>
escribió:
… @JJ <https://github.com/JJ> and @antoniogamiz
<https://github.com/antoniogamiz>, don't listen to my babbling too much,
but I am still learning @antoniogamiz <https://github.com/antoniogamiz>'s
strategy which looks better the more I look at it. The thoughts I put down
yesterday are mostly wrongish, but I have more hope for today's direction.
I think the main problem is the disconnect between the Documentable file
tree and the using doc repo layout.
I plan to try a slightly different tack today back toward a slightly
different layout.
Good luck to both of you for the new school year!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPOAR75HK5MVRTPZIDPMPTQKYASBANCNFSM4ITAPMPQ>
.
|
You are correct, but I'm trying to clearly distinguish between installation of the Document module versus using the installed documentable in a doc repo--mainly to help my understanding of the process, if nothing else. |
The problem with using resources directory is that we need to list every file in For now, as for the configuration file, I will store it in a directory called |
After much work trying to implement my suggestions, I think you may be at least partially correct. I have experimented with the Build.pm6 but it cannot do all it needs to do with the current state of zef. The only problem I see with the zipped archive is how it should be part of the build process and not a separate dev step. I have reverted to putting file names back into the META6.json and don't think that is too burdensome. At the moment I am trying to clearly separate the files needed for testing versus the files needed for setup: quite a chore. |
I'm closing this for now. |
I will try to address these problems in the near future. |
When akiym/JSON-Hjson#3 is resolved, I will include it. |
I have seen that YAML supports comments by default, so maybe we should that instead of JSON or HSON. |
The module above has been released anew, check it out. |
I know, I propelled that release. But as YAML has a shorter syntax and has comments support by default, I think it's a better option. |
Your call. As long as you have to use an external module, I guess YAML is as good as HJSON or even JSON. |
Some thoughts I have from initially playing with documentable in a fork of the doc repo:
I would put the default config.json in a config-default directory.I would have the user put his config.json in a config-user directory (to be read-only for documentable after setup).The text was updated successfully, but these errors were encountered: