Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate css from plugin scss on build #220

Open
finanalyst opened this issue Mar 19, 2023 · 0 comments
Open

Generate css from plugin scss on build #220

finanalyst opened this issue Mar 19, 2023 · 0 comments

Comments

@finanalyst
Copy link
Collaborator

Plugins typically contain SCSS files from which CSS is generated. Normally the CSS is generated by a developer to test the plugin. Sometimes this does not happen. The CSS is then not the intended one. This occurred for a style change to the Programs tab.
There is a bash utility in this repo called update-css, which generates the CSS from SCSS on a per-plugin basis.
I suggest that part of the build process should be to run update-css. If this is a good idea, then

  1. update-css should be changed to ensure that all plugins are checked if no argument is provided to it
  2. dart scss needs installing in the build environment (as documented in the README)
  3. update-css is run each build (dart scss does not change anything if the css is more recent than the scss).

@dontlaugh is this reasonable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant