New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade secondaries
plugin resolves multiple issues
#245
Conversation
Creates secondary files with names that can have unicode characters, Filesystem characters. Improves escaping in search bar. Improves content of secondary files. - Discussion of urls in discussion #99 - resolves long outstanding issue #198 (from Raku/doc, 2019) - resolves issue #70 about <== - resolves issue #181 about pages not being generated To handle `=head1 X<Function name|Syntax, name>` type blocks, more information is needed from `Raku::Pod::Render`. Fez is not accepting the updated distribution. This PR is likely to fail until Fez issue is resolved.
This PR is failing because it relies on |
The map directive is well documented. The prettyurls file is generated when the html are built. Essentially, secondary files are generated with human-readable characters, including `/` and unicode. These are hash encoded and mapped to files in the `hashed/` directory. The route directive was added after discussion with the Caddy maintainer. Basically, Caddy by default runs `try_files` before `error`, which generate errors for given routes. Since we want `/hashed*` routes to be illegal from the outside, `errors` must run before the `try_files` directive.
The result of this refactor, running off a Caddy server with the new Caddyfile can be seen at new-raku. Try searching for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick questions, may have more.
Need to address the conflicts. |
@coke This refactoring will not build until The problem is a bug in fez which will be fixed in release 52. Once that lands, I will fix up the other conflicts here. |
Can you elaborate? |
The issue is raised in the fez repo, and a fix is forthcoming. |
@coke @dontlaugh fez v-52 is now available and Collection and Raku::Pod::Render have been updated. |
The build is now passing, the conflicts have been resolved. |
Doing a merge commit, since rebase was off the table and there were multiple commits I didn't want to squash. |
Creates secondary files with names that can have unicode characters, Filesystem characters. Improves escaping in search bar. Improves content of secondary files.
=head1 X<Function name|Syntax, name>
type blocks, more information is needed fromRaku::Pod::Render
. Fez is not accepting the updated distribution. This PR is likely to fail until Fez issue is resolved.