addresses issue #244 adds a copy button to code blocks #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch affect `Website/ogdenwebb` by changing the template for block code to add a button, adding the js code to core.js, and adding CSS for the button (placing on top left of block). The JS has been tested for Firefox. Uses `execCommand`, which is deprecated because Firefox does not recognise all of Clipboard API. This took a while to get a copy that would remove all HTML but respect whitespace. MINOR change to `lists` CSS to align bullets with left margin.
|
I don't see any code to actually do the copying here, just changes to generated HTML/CSS |
|
@coke whoops. missed adding the change to core.js |
The patch affect `Website/ogdenwebb` by changing the template for block code to add a button, adding the js code to core.js, and adding CSS for the button (placing on top left of block). The JS has been tested for Firefox. Uses `execCommand`, which is deprecated because Firefox does not recognise all of Clipboard API. This took a while to get a copy that would remove all HTML but respect whitespace. MINOR change to `lists` CSS to align bullets with left margin.
coke
reviewed
May 2, 2023
|
Tested on chrome on windows, OK. |
coke
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch affect
Website/ogdenwebbbyThe JS has been tested for Firefox. Uses
execCommand, which is deprecated because Firefox does not recognise all of Clipboard API.This took a while to get a copy that would remove all HTML but respect whitespace.
MINOR change to
listsCSS to align bullets with left margin.