Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetHash -- not documented. #2412

Closed
bbkr opened this issue Oct 23, 2018 · 0 comments
Closed

SetHash -- not documented. #2412

bbkr opened this issue Oct 23, 2018 · 0 comments
Labels
good first issue If you want to dive in, this would be a good place to start

Comments

@bbkr
Copy link
Contributor

bbkr commented Oct 23, 2018

The problem

In SetHash section "a convenient shorthand idiom for adding an element to a SetHash" ($fruits<cherry>++) is explained. But corresponding convenient idiom $fruits<cherry>-- for removing items from SetHash is not mentioned despite the fact that it is officially in spec: https://github.com/perl6/roast/blob/master/S02-types/sethash.t#L67

Suggestions

Change this section to "a convenient shorthand idioms for adding and removing an element".

Thanks!
@bbkr bbkr added good first issue If you want to dive in, this would be a good place to start easy to resolve labels Oct 23, 2018
chsanch added a commit to chsanch/doc that referenced this issue Oct 24, 2018
@chsanch
Fix Raku#2412 - Add More examples in SetHash
52a04b7 
Add examples for removing SetHash elements
@JJ JJ closed this as completed in 4c715da Oct 25, 2018
JJ added a commit that referenced this issue Oct 25, 2018
@JJ
Merge pull request #2417 from chsanch/fix-2412
70ac793 
Fix #2412 Add examples for removing SetHash items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue If you want to dive in, this would be a good place to start
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbkr