Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callframe issues #2719

Open
4 of 5 tasks
JJ opened this issue Apr 18, 2019 · 1 comment
Open
4 of 5 tasks

Callframe issues #2719

JJ opened this issue Apr 18, 2019 · 1 comment
Labels
docs Documentation issue (primary issue type) NOTSPECCED need roast tests before documenting
Milestone
backlog

Comments

@JJ
Copy link
Contributor

JJ commented Apr 18, 2019 •
edited

The problem

This SO question drew our attention to CallFrame. It didn't really raise an issue with respect to that documentation, but there are some improvements that can be made.

Suggestions

  • Adjust method/sub definitions to actual definitions in Rakudo
  • There are some undocumented methods, like new. Check whether they are spec.
  • It's not true that *there's no way to instantiate a CallFrame". CallFrame.new works.
  • Maybe add some examples.
  • level is not defined in the source. Unless it's inherited from Mu, I don't see how that would work.
JJ added a commit that referenced this issue Apr 18, 2019
@JJ
Reflow, eliminates level
10db477 
And some general cleanup as an initiation for #2719
JJ added a commit that referenced this issue Apr 18, 2019
@JJ
Reflow and adapts definitions, refs #2719
098a505
@JJ JJ added the docs Documentation issue (primary issue type) label Apr 19, 2019
@JJ
Copy link
Contributor Author

JJ commented Apr 19, 2019

new is not spec, or tested: rakudo/rakudo#2853

JJ added a commit that referenced this issue Apr 19, 2019
@JJ
Revise CallFrame
d463a81 
Also have a look at history, like this commit
rakudo/rakudo@7966dad
where it lost `level`. Eliminates references to it, and some grammar
corrections. Refs #2719
JJ added a commit that referenced this issue Apr 19, 2019
@JJ
Adds example for .code, refs #2719
e90d7c1
JJ added a commit that referenced this issue Apr 19, 2019
@JJ
Wraps up refs #2719
fbddb56
@JJ JJ added the NOTSPECCED need roast tests before documenting label Apr 29, 2019
@coke coke added this to the backlog milestone Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation issue (primary issue type) NOTSPECCED need roast tests before documenting
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@JJ @coke