change p6 to raku, chg .perl to .raku #3251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJ
reviewed
Feb 26, 2020
| @@ -1878,4 +1878,4 @@ live on GitHub. An online converter may become available at some point. | |||
|
|
|||
| =end pod | |||
|
|
|||
| # vim: expandtab softtabstop=4 shiftwidth=4 ft=perl6 | |||
| # vim: expandtab softtabstop=4 shiftwidth=4 ft=raku | |||
There was a problem hiding this comment.
This is the problem with massive PRs with many files: there might be one quirk and everything goes tumbling down. In this case, I'm not sure this would work (for those using vim). It might, however.
JJ
requested changes
Feb 26, 2020
| say so 'properly' ~~ /^ perl/; # OUTPUT: «False» | ||
| say so 'perly' ~~ /^ perl/; # OUTPUT: «True» | ||
| say so 'perl' ~~ /^ perl/; # OUTPUT: «True» | ||
| say so 'prorakuy' ~~ / raku/; # OUTPUT: «True» |
There was a problem hiding this comment.
This is not good... Again, probably better to PR just a file or a bunch of files... You might have changed some occurrence of Perl
| @@ -1061,7 +1061,7 @@ In Raku this is similar, you merely needs to change the name. As you probably | |||
| guessed, you just need to use C<PERL6LIB>: | |||
| @@ -680,7 +680,7 @@ Universal interface for positional access to zero or more elements of a | |||
| say @alphabet[1]; # OUTPUT: «b» | |||
| say @alphabet[*-1]; # OUTPUT: «z» | |||
| say @alphabet[100]:exists; # OUTPUT: «False» | |||
| say @alphabet[15, 4, 17, 11].join; # OUTPUT: «perl» | |||
| say @alphabet[17, 0, 10, 20].join; # OUTPUT: �raku» | |||
There was a problem hiding this comment.
This looks weird... The rest too, come to think of it. Someone has changed that...
|
Forget it for now. |
|
Thanks anyway, I appreciate your effort. If would be great if you spun off some of them... They could go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.