Add EditorConfig file #3372
Closed
Add EditorConfig file #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref [EditorConfig](https://editorconfig.org/) followup or may help #3349 #3280 ;-)
JJ
reviewed
May 7, 2020
There was a problem hiding this comment.
Not sure about this. It's adding (which implies maintaining) other file. Wouldn't it be better to stash it somewhere else, say a gist, and link it from somewhere here? Like CONTRIBUTING.md?
Then there's the slippery slope: add config for emacs, Code, Atom... Comma...
|
As you wish! That is only a proposal. Feel free to close it. :-) |
|
Well, I said I was not sure, and I'm not one to throw away other people's work... If you think it's better in the repo, so be it (you'll have to maintain it anyway, and document elsewhere that we have it there). But, as I said, I'd like to hear some more opinions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref EditorConfig
followup or may help #3349 #3280 ;-)