Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description of three new DateTime methods #3860

Merged
merged 7 commits into from Jun 14, 2021
Merged

Add description of three new DateTime methods #3860

merged 7 commits into from Jun 14, 2021

Conversation

tbrowder
Copy link
Member

@tbrowder tbrowder commented Apr 3, 2021

The problem

Three new methods have been added to class DateTime to Raku for the next release (via merged Rakudo PR #4288) and need documenting:

  • day-fraction
  • julian-date
  • modified-julian-date

Solution provided

Proposed doc entries for the three new methods.

@tbrowder tbrowder marked this pull request as draft April 3, 2021 20:16
@tbrowder tbrowder marked this pull request as ready for review April 3, 2021 21:02
@tbrowder tbrowder marked this pull request as draft April 3, 2021 21:03
@tbrowder tbrowder marked this pull request as ready for review April 3, 2021 21:07
Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, maybe you'd want to address the nitpicks.

doc/Type/DateTime.pod6 Show resolved Hide resolved
doc/Type/DateTime.pod6 Outdated Show resolved Hide resolved
doc/Type/DateTime.pod6 Outdated Show resolved Hide resolved
doc/Type/DateTime.pod6 Show resolved Hide resolved
@tbrowder tbrowder marked this pull request as draft April 4, 2021 12:58
@tbrowder
Copy link
Member Author

tbrowder commented Apr 4, 2021

I'll keep tweaking this and hopefully be happy (and make critics happy) with it in time for the upcoming release :-)

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge when you think it's ready.

@tbrowder tbrowder marked this pull request as ready for review June 14, 2021 18:55
@tbrowder
Copy link
Member Author

I'm ready for this to be "run up the flag pole and see if anyone salutes it" if you are.

@JJ JJ merged commit a1f104e into Raku:master Jun 14, 2021
@JJ
Copy link
Contributor

JJ commented Jun 14, 2021

Done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants