Fix example output #4275
Merged
Fix example output #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2023 09:15
The length of a vector (2,3) is most definitely not 6. Change the number to give nice integral values.
"Criterium" is a form of bicycle race. What is wanted here is the singular of "criteria" which has Greek roots. The correct singular is "criterion".
|
Good catch- shouldn't the second updated example print 13? |
|
No. The point of the second example is that it doesn't update the length.
…On Wed, 22 Mar 2023, at 09:52, Will Coleda wrote:
Good catch- shouldn't the second updated example print 13?
—
Reply to this email directly, view it on GitHub <#4275 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNBTNYHN577TCI7POERBPDW5IWJZANCNFSM6AAAAAAWDBTCYA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The length of a vector (2,3) is most definitely not 6.
Solution provided
Change the numbers to give nice integral values, with the correct output.