Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force_gc opcode name inconsistent #613

Closed
coke opened this issue Apr 14, 2020 · 6 comments
Closed

force_gc opcode name inconsistent #613

coke opened this issue Apr 14, 2020 · 6 comments

Comments

@coke
Copy link
Contributor

coke commented Apr 14, 2020

force_gc has an underscore to separate words, where most opcodes mash them together and reserve underscore for type variants.
@coke
Copy link
Contributor Author

coke commented Apr 21, 2020

Also: positional_get and associative_get

@MasterDuke17
Copy link
Contributor

I vote for changing their names, but don't have strong feelings either way.

@MasterDuke17
Copy link
Contributor

Also associative_bind and smrt_*

@coke
Copy link
Contributor Author

coke commented Apr 24, 2020

lstat_time

@coke
Copy link
Contributor Author

coke commented Apr 24, 2020

Nine points out this risks breaking users for little benefit, closing ticket.

@coke coke closed this as completed Apr 24, 2020
coke added a commit that referenced this issue Apr 24, 2020
@coke
Note concern raised in #613
180a936
@MasterDuke17
Copy link
Contributor

Ha! https://gist.github.com/jnthn/e81634dec57acdea87fcb2b92c722959#gistcomment-3274977, "(The number of times I wrote nqp::forcegc...)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coke @MasterDuke17