Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Path to raku #89
Path to raku #89
Changes from 22 commits
07c423e
6b444bd
0b5402e
d71dc5c
bf7ab78
e5c5d42
7d0aab8
a79dde0
1ee0908
66daa4f
8d86f07
3c0fee6
7188f39
1c2ece9
e4461ed
985934b
e35a5ac
48793de
084ca0a
31a0038
92fd411
cfd072d
c5cb2c9
04108b1
9301d09
b9c597b
87d4343
535d778
dd6054c
d14804e
ce377bd
2f5794b
1b89762
2b237b5
f3d057a
6b00410
3118a7e
531b628
15a8451
a1e9c80
25916df
59d8608
2e477d6
2c7aeaf
a264ae4
62c083d
bcf6c87
235ae7d
6af3f53
115a260
dcd66a7
0dc6534
6b2ddf8
50f7697
998232a
50c14e2
24fddab
5789db0
01efd7e
813165e
3021673
52b02f8
b96dff1
749a9a2
7faff8b
9310222
9285582
90b8d0c
43a1c6d
6e7e625
e0185a4
9bcb834
69786a2
0de1d74
dd8dcd5
dc7f451
2d57afe
51890eb
4cad6d4
71e9405
7257d5e
e09f6c2
2d7b3f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either don't mention Wikipedia or talk about it differently. Currently the text reads as if we encourage people to rename things on wikipedia, which we definitely shouldn't do. In fact, the wikipedia page for Raku will probably be called Perl 6 for a significant amount of time after the rename, until Raku becomes more common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed with d14804e I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, please absolutely delete the mention of Wikipedia. Wikipedia is its own thing with its own rules. Of course it's great to encourage contributions to it, but implying that users should go there and tweak mentions of Perl 6/Raku can be seen as malice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the light of extension discussion, can we add one last thing here:
.rkt
for test files. This would resolve conflicts with perl5 support in IDEs like Atom and intelliJ.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #101 (comment).
My understanding is that we should keep using .t, and encourage people to put the right shebang (one that has
raku
in it).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shebang won't help those poor things which solely rely on file extensions. For example, I'm currently bound to Atom. Kind of. Because when I need to edit Perl5 code I use Vim because Atom can only work with either perl5 or perl6 module but no both at the same time. The reason? Both claim for
.t
extension.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vrurg seems like something specific to atom that is fixable, see https://discuss.atom.io/t/can-atom-interpret-my-bin-bash-shebang/47234.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexDaniel the point is that only one of perl5 or perl6 package can be active at any given moment, not both of them. So, there is no use for detecting shebang if there is no language to bind to.
Besides, intelliJ doesn't allow file type switching whatsoever. So, you either see
.t
as perl5 or perl6. Always. Because we said so!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with some others that the filenames should not be part of this pull request, and are better left to another place, where we can have a nice listing of possibilities and decide which out of those we think work best. Or this could be changed to just be suggestions for filenames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's the plan? Perhaps add a sentence like “We will be striving to keep the community together”, or whatever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully addressed in f3d057a .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't think the message is strong enough. I'd prefer to see a clear message explicitly defining our vision. “is also intended to have a healing” sounds a bit too weak to my liking, but see yourself, I won't be insisting on changing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, some may see it like that, but at least speaking for myself, I don't want to think of it as "leaving" at all. I think I'd phrase it as "welcome the rename, as they don't want anything to do with the language and are glad to disassociate it from the Perl name".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd phrase this more like "There are community members with an active interest in both Perl 5 and Raku, and some of those who only do one or the other still feel there is much to be learned from, and shared with, each other, especially given the many shared design values of the languages."