Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fudges for all implementations other than rakudo[.moar|.jvm]? #235

Closed
ronaldxs opened this issue Feb 16, 2017 · 4 comments
Closed

Comments

@ronaldxs
Copy link
Contributor

In a discussion on a pull request to fix niecza fudge misspellings it was suggested that we remove all niecza fudges - PR 229. The current tally of fudge implementation usage is below:

implementation Count by occurrence
kp6               1
mildew            6
niecza         1475
rakudo          756
rakudo.jvm      300
rakudo.moar     353

Besides niecza there are only 7 fudge specifications for implementations other than rakudo. Is it agreed to remove all implementation fudges not related to rakudo?

@usev6
Copy link
Contributor

usev6 commented Feb 16, 2017

I'm in favor of such a consolidation.

@coke
Copy link
Contributor

coke commented Feb 16, 2017

Please do. Anyone coming back to niecza development (e.g.) at this point is going to have to start over regardless.

Please do it as one commit per implementation, so if someone wants to restore a particular one, it's as easy as possible for them.

@ronaldxs
Copy link
Contributor Author

In some cases #?niecza fudges also have #?DOES directives and in 11 of those cases niecza is the only fudge implementation so removing the #?niecza will leave a #?DOES with no implementation. Since there are already 90+ existing cases of #?DOES with no implementation, I am only planning to remove non rakudo implementation directives and will not remove any #?DOES directives. Please reply if you have any objection to my conclusion on #?DOES.

Since there are about 1500 non rakudo fudge implementation directives I had to write a program to search for #?DOES directives with either no implementation or niecza as the only implementation. The program is a modified version of fudge-usage-stat.pl from PR #228 and I do not guarantee the counts are right but hope and believe so.

@samcv
Copy link
Contributor

samcv commented Feb 18, 2017

I am for this too. Good plan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants