Skip to content

Commit

Permalink
Auto merge of #114494 - est31:extend_useless_ptr_null_checks, r=jackh726
Browse files Browse the repository at this point in the history
Make useless_ptr_null_checks smarter about some std functions

This teaches the `useless_ptr_null_checks` lint that some std functions can't ever return null pointers, because they need to point to valid data, get references as input, etc.

This is achieved by introducing an `#[rustc_never_returns_null_ptr]` attribute and adding it to these std functions (gated behind bootstrap `cfg_attr`).

Later on, the attribute could maybe be used to tell LLVM that the returned pointer is never null. I don't expect much impact of that though, as the functions are pretty shallow and usually the input data is already never null.

Follow-up of PR #113657

Fixes #114442
  • Loading branch information
bors committed Sep 16, 2023
2 parents dd04d84 + f777cc5 commit 9d2372e
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9d2372e

Please sign in to comment.