Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types implementing IAsyncDisposable should also implement IDisposable #679

Open
RalfKoban opened this issue Nov 20, 2023 · 0 comments
Open

Types implementing IAsyncDisposable should also implement IDisposable #679

RalfKoban opened this issue Nov 20, 2023 · 0 comments
Labels
Area: analyzer Area: maintainability feasability unclear feature
Projects
MiKo Analyzers

Comments

@RalfKoban
Copy link
Owner

Classes that implement IAsyncDisposable should typically also implement IDisposable to be prepared for either synchronous or asynchronous disposal. Only in case the disposal cannot be done synchronously, they do not need to implement IDisposable.

https://learn.microsoft.com/en-us/dotnet/standard/garbage-collection/implementing-disposeasync
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: analyzer Area: maintainability feasability unclear feature
Projects
MiKo Analyzers
  
Unclear
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RalfKoban