Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show power source type on detailed screen in soldering mode #1708

Closed
ia opened this issue Jun 16, 2023 · 2 comments
Closed

Show power source type on detailed screen in soldering mode #1708

ia opened this issue Jun 16, 2023 · 2 comments
Assignees
Labels
Enhancement New feature or additional function.

Comments

@ia
Copy link
Collaborator

ia commented Jun 16, 2023

Hello.

Rationale

  • There is a separate option for detailed screen in soldering mode already.
  • There is still a bit of some free space left on OLED in detailed screen which can be used for additional related info.
  • Sometimes fancy power protocol label on power plug != actual negotiated power type on a device.
  • Code to detect a type of power source & to display it, and required characters - everything is already there (triple WIN!) but only for debug menu :( ... yet ;)

Hence,

Proof-of-Concept

Here is how it could look:

Quick Charge
Power Delivery
Sleeping
DbgMenu QC
DbgMenu PD

Patch

In the next few minutes I'm going to make a pull request. But I create this feature request as issue report for documentation purposes in case if someone else will be looking for this feature searching through opened & closed issues.

Disclaimer

I'm sorry if I'm messing too deep with source tree by modifying essential core methods/functions. But I think that this feature fits perfectly for the detailed info screen option. A few notes:

  • I did make all the builds successfully: one language per every model including S60.

  • I did make model=TS80P firmware-EN build, flashed it and tested successfully: I've never before flashed "consumer" hardware with untested unverified firmware with my own changes but surprisingly so far my unit seems to work and I hope that magic smoke is still deep inside, and what I see & smell are just fumes from leftovers of flux on the tip from the previous soldering session.

  • Although current location of power type is too close to big temp degree logo, I decided to put power type right under sleep timer anyway: for aesthetic align reasons ... and for the ease of calculation of pixels' location.

  • Once the device goes to sleeping mode, power type label disappears (just like timer) - at first I thought to make it visible all the time but now I think that the way how it works even better: that empty part of the screen in the middle (i.e., without timer & power type) gives more effective & fast visual feedback about device being in sleep mode.

As always, can't wait to hear any feedback. Wouldn't you want to see a power type right on the soldering screen?

@ia ia added the Enhancement New feature or additional function. label Jun 16, 2023
@ia ia assigned Ralim Jun 16, 2023
@Ralim
Copy link
Owner

Ralim commented Jun 16, 2023

My feedback on this is fairly simple:
👍🏼 Looks good and makes sense.
I dont use detailed view so I dont have a personal opinion on it aesthetically.

@discip or @River-Mochi May have stronger opinions 😁


On the code side, never feel bad if you reach into lots of code for a PR; thats what the PR is there for. If its too messy it's often a sign of needing some abstraction or cleanup.

Generally if the firmware builds it should run and work. Only risk is you somehow get heater stuck on, which will make tip get hot - fast. (and you can unplug if that happens). Otherwise you shouldn't be able to cause permanent damage.

Ralim pushed a commit that referenced this issue Jun 18, 2023
…1709)

* Show power source type on detailed screen in soldering mode (#1708)

* Update according to code review
@ia
Copy link
Collaborator Author

ia commented Jun 18, 2023

  • Implemented.

@ia ia closed this as completed Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or additional function.
Projects
None yet
Development

No branches or pull requests

2 participants