Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecil pd tweaking #1272

Merged
merged 18 commits into from
Apr 3, 2022
Merged

Pinecil pd tweaking #1272

merged 18 commits into from
Apr 3, 2022

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Apr 2, 2022

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?
  • Raise PD max voltage to 21V (for PPS)

  • Adding a PD read out menu

  • Cache VBus mod a bit

  • Add VBus mod info to PD menu as well

  • What is the current behavior?

  • What is the new behavior (if this is a feature change)?
    If on Pinecil, and you boot while holding the front button (+), it will allow inspecting the PD data.
    Pressing the rear button (-) will exit the menu and continue boot
  • Other information:

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

Is this only applicable to the Pinecil?
Could this work for the miniware devices as well?
Or is certain hardware required for this to work which is not present in miniware devices?

@Ralim
Copy link
Owner Author

Ralim commented Apr 2, 2022

The code will not fit on the TS80P sadly

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

Oh that's a pity.
Even if some KBs would be shaved of as @alvinhochun suggested?

btw
Did you have time to check how to save space by removing hall related stuff?

@Ralim
Copy link
Owner Author

Ralim commented Apr 2, 2022

Its only a few bytes saved; so not enough.
And I dont have a lot of time at the moment to spend on this part of IronOS; and this is mostly a feature requested by the Pinecil chat, so focusing there first. 😓

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

No worries, you don't need to feel bad about that! 😃
Just thought of being able to check PD readings without having to use an external device.

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

What changes for the TS80P regarding 9689c05?

@Ralim
Copy link
Owner Author

Ralim commented Apr 2, 2022

Not using freestanding mode so lto can drop a tiny bit more code. Frees up around 200 bytes, enough that we squeeze in

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

Does that affect the accuracy or the performance some how?
What is freestanding mode for?
Sorry for this questions, but I really don't understand much about this. 😓

@Ralim
Copy link
Owner Author

Ralim commented Apr 2, 2022

Should not, just trades off different types of optimisation :)

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

What about the hall related stuff @alvinhochun brought up instead?

@Ralim
Copy link
Owner Author

Ralim commented Apr 2, 2022

It will save like 5 bytes; which is not a huge amount 🤣

@discip
Copy link
Collaborator

discip commented Apr 2, 2022

You raised my concern by adding the crying smiley (😢) to the commit, what was it than about if there is nothing worrisome?

@Ralim Ralim merged commit a73f634 into master Apr 3, 2022
@Ralim Ralim deleted the pinecil-pd-tweaking branch April 3, 2022 02:58
@River-Mochi
Copy link
Contributor

River-Mochi commented Apr 4, 2022

here is some testing (video) I did with multiple chargers. only weird thing is that I am seeing 3.5amps on chargers that say on box max 3.25amps. non_daniel said I can not trust the 3.5amps.
Also I did some testing with a USB-Tester between the Pinecil and the Charger, and I notice if I flip the cable over , then I get a State 6 instead of a State 12. here you will see the special EPR (240W cable) but I got the same results with my 100W emark cable.
Here I'm testing on 3 different chargers (1-white no name 'cirtek' brand, 2- pinepower desktop, 3- some low cost PD65W charger small black one)

notice when I flip the Cable that is plugged into the right side of the USB-tester, I get State 6
sometimes I don't get state 6 when I move from one charger to the next charger, but as soon as I RESET the tester button on the top, then I can repeat the problem over and over. The tester is doing something to cause this? notice also when I flip the cable I don't see the Welcome message on the tester.

https://www.youtube.com/watch?v=dxAC8iQOVy0&ab_channel=RiverB.

The tester I am using. https://smile.amazon.com/gp/product/B07DCTG6LH

Separately, I notice that some of my chargers that said they were 3.25Amp only show as 3.0amps.
also my Pinepower gives 20.7 V which rounds up to 21V on Pinecil display right side. however in the PD debug menu, I only see PinePower showing as 20V. could it should an extra digit like 20.7v or round up?

@River-Mochi
Copy link
Contributor

I also am getting [5 20v 3.5amps] just using a normal PD60W cable to Pinepower and I don't think I should be seeing 3.5amps on that cable?

This is using the red USB-C cable I bought from Pine64 + PinePower desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants