Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S60 Support #1692

Merged
merged 54 commits into from Jun 3, 2023
Merged

S60 Support #1692

merged 54 commits into from Jun 3, 2023

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented May 28, 2023

This is the draft support for the S60; goes hand-in-hand with #1546

This is here to track this, until we at the least resolve movement and calibration

Still to do:

  • Need to add movement detection
  • Tip PWM needs refinement to allow 12V operation
  • Buzzer isn't used
  • Calibration isnt amazing
  • OLED needs re-work to handle larger screens

@Ralim Ralim added this to the 2.22 milestone Jun 3, 2023
@Ralim Ralim self-assigned this Jun 3, 2023
@Ralim Ralim marked this pull request as ready for review June 3, 2023 09:41
@Ralim Ralim merged commit 286afad into dev Jun 3, 2023
22 checks passed
@Ralim Ralim deleted the S60 branch June 3, 2023 10:05
@discip
Copy link
Collaborator

discip commented Jun 16, 2023

@Ralim
Today I was testing the latest commits on my devices and unfortunately found that after this PR the OLED on the TS80P started to show artifacts when the buttons were pressed!
Especially in transitions!

@Ralim
Copy link
Owner Author

Ralim commented Jun 18, 2023

The only transition I had to adjust was the scroll down animation. I've pushed to dev a small tweak to hopefully make it be better.

But realistically when I figure out the heck to handle mixed OLED screen sizes well all the animations will need to be refactored

@thetooth
Copy link

Tested this out today, no issues flashing and booting into ironOS menu but I have one little problem. The iron produces no heat, no current draw or updates to ADC. If I power up the iron I get a reading of 18 matching ambient, heating the tip externally I don't see any change to the read out, only after power cycling do a see a higher plausible value. Checking PB8 there is no activity but other GPIO/peripherals (buttons/oled) working fine.

Looking into this, I might be wrong but you are using the official stm32 HAL while my hardware is using a CKS32F103C8T6 clone, I tried swapping around the timer peripherals in case one of them is pretend on my particular chip but no luck.

@thetooth
Copy link

Annnnnnnd the second I complain I find the problem. hub238_has_run_selection() fails, I'm not using USB PD for any of this so maybe that's why? Anyway removing that check makes the iron live, good job with the PWM tune, it works about 100x better than the stock firmware.

@Ralim
Copy link
Owner Author

Ralim commented Jun 26, 2023

Ahhhh,

Yep that would do it. All the material I saw focused on PD so that was my focus. Will add DC fallback support.

Glad to hear the tune is to your liking, i found it substantially better but keen to hear thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants