Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bit of clean-up & update configuration.h files #1717

Merged
merged 2 commits into from Jun 20, 2023
Merged

A bit of clean-up & update configuration.h files #1717

merged 2 commits into from Jun 20, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jun 20, 2023

What do you think?

@Ralim
Copy link
Owner

Ralim commented Jun 20, 2023

This looks good, could you please try to fill out the PR template that auto-spawns though, its used to ensure its easier to grep them for release notes 😅

@Ralim Ralim merged commit 0a3dfb3 into Ralim:dev Jun 20, 2023
13 checks passed
@ia
Copy link
Collaborator Author

ia commented Jun 20, 2023

could you please try to fill out the PR template that auto-spawns though, its used to ensure its easier to grep them for release notes

Ooops... aaaaha, so that's why it's there! Pardon, I just thought that it's more like formality and/or copy-paste from bug report form or something like that. Got it, no problem!

@Ralim
Copy link
Owner

Ralim commented Jun 20, 2023

Its certainly not perfect, but its there mostly to give me a 15 second quick reference when making release notes; as well as some other often useful information. I view it as best-effort; but it helps when you look at something months later 🤣

@ia
Copy link
Collaborator Author

ia commented Jun 20, 2023

it helps when you look at something months later

Yes-yes, makes perfect sense. I fully got it now. Just didn't realize it first. :)

@ia ia deleted the conf branch June 21, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants