-
-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic code style refactoring: add enum for screen orientation & define for OLED state #1732
Conversation
…purpose regardless its one-time & temporal
… to propose better code read-ability in my humble vision from the side, didnt touch any functionality only cosmetic syntax
… macros for ON/OFF OLED state instead of magic numbers
…ED state instead of magic numbers, trying unify common style for the whole file for better read-ability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me.
You really like annotating the #endif
dont you? Doesnt your IDE do that for you 😁
Had a couple of problems in the past due to not having them. ;)
Touche`! :D |
What kind of change does this PR introduce?
Cosmetic code style refactoring. Main changes:
And so on.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Other information:
It's more like experiment than anything else and I hope I didn't mess much with preferable style but I just tried to unify code style in files which I updated anyway. Can't wait for feedback.
Made builds successfully and tested firmware on
TS80P
but there shouldn't be any difference since there is no any functionality update.