Move check-style core logic from makefile to shell script #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o deploy.sh:check_style_file function
|
I'm all for this. |
Ooops... I just wasn't too careful - thought it's some legacy target. Sure-sure, no problem at all! Sorry. But that's why a few pairs of eyes better than one after all. 👉 👈 |
|
Hahaha it's no problem at all 😜 I missed it in the noise until I tried to use it 😊 |
|
Sorry-sorry, now it's back. And I think I'm done with the commits for this PR unless you have any other suggestions. |
Ralim
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Move check-style core logic from
source/Makefile:check-styletarget toscripts/deploy.sh:check_style_filefunction.What is the current behavior?
If there is a need to maintain / modify core logic of check-style inside Makefile, it's crossing of bash syntax & makefile syntax which makes it look very inconvenient and disallow to put even per-line comments.
What is the new behavior (if this is a feature change)?
To change/fix/update
check-styleparsers & logic, now it represented as a shell function insidedeploy.sh.Other information:
This is not ideal, but I think it should make it more "maintainable": just like for some other stuff to load off makefile there are python scripts, putting shell stuff into sh script looks reasonable. Plus, consider this as PoC for first iteration. Maybe later I figure out how to make it even more clear and come back on that with another one PR.