Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /build/source by /build/ironos to eliminate ambiguity with /build/source/source #1748

Merged
merged 3 commits into from Jul 20, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 20, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Tiny change of the directory name inside docker container.

  • What is the current behavior?
    The root project directory mapped/copied to /build/source/ inside of docker container. But since there is source directory inside the root project directory already, sometimes it leads to ambiguity.

  • What is the new behavior (if this is a feature change)?
    The root project directory mapped/copied to /build/ironos inside of docker container.
    Plus tiny refactoring buildAll.sh only to use variables for directories instead of hardcoded paths just in case.

  • Other information:
    Just another one tiny "ci beautify" suggestion. :)
    It shouldn't affect anything else though - I tested it locally by running make docker-build and all output files have been generated where they supposed to be.

@Ralim Ralim merged commit 297a4df into Ralim:dev Jul 20, 2023
15 checks passed
@ia ia deleted the build-ironos branch July 23, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants