Fix github CI clang-format related check_c-cpp job #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now it's shellcheck little report, hold on, please... |
Ok, now it seems good to go. |
Ralim
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix github CI clang-format related check_c-cpp job.
What is the current behavior?
After
check-stylelogic has been moved to shell script,make check-stylecalls it but because bash is missing in the container, script can't run the check!What is the new behavior (if this is a feature change)?
It should be fixed with these changes.
Other information:
I'm terribly sorry!!! But it seems this particular job is cursed! It's the second time already when according to log there is a problem but github CI just can't track down such ease-to-automate checks for users. Not excusing my own responsibility here though! (going to a chalk board) I will be checking build steps' logs on github after changing scripts for build steps. I will be checking build steps' logs on github after changing scripts for build steps. I will be ... (not copy pasted BTW)