Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement target in Makefile to run github CI-like checks locally #1753

Merged
merged 2 commits into from Jul 23, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 22, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Implement target in Makefile to run github CI-like checks locally.

  • What is the current behavior?
    Currently there is no fast & easy way to run tests & checks before commit locally.

  • What is the new behavior (if this is a feature change)?
    Command make tests runs the same tests & checks as github CI jobs for pull-request but locally.

  • Other information:
    I understand the irony that the whole point of CI philosophy is to use "big" & "fast" infrastructure to test code instead of small & slow local PCs. But for someone like me this should help to reduce a bit those awkward embarrassing moments when PR turns red only because I forgot tab in python script or some quotes in shell script. 😳

@Ralim Ralim merged commit f83ebc8 into Ralim:dev Jul 23, 2023
15 checks passed
@ia ia deleted the make-tests branch July 23, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants