Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bit more 'transparent' V calibration #1758

Merged
merged 35 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
43e13c3
finer resolution
discip Apr 6, 2023
1cba3ea
Update settingsGUI.cpp
discip Apr 7, 2023
634d24d
Update settingsGUI.cpp
discip Apr 8, 2023
0ecccc6
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 8, 2023
8ee98fa
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 10, 2023
420a466
Update settingsGUI.cpp
discip Apr 10, 2023
a719c82
test
discip Apr 10, 2023
4cdba6e
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 18, 2023
f192ae3
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 24, 2023
4aa56ea
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 25, 2023
7943a26
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 27, 2023
6439143
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Apr 28, 2023
8f656a3
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip May 8, 2023
d9d2771
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip May 16, 2023
7b53041
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip May 17, 2023
9af416a
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip May 22, 2023
2a0c31c
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 5, 2023
7b139d6
Update settingsGUI.cpp
discip Jun 5, 2023
80da33f
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 16, 2023
610ec30
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 17, 2023
933047c
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 20, 2023
26cd462
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 29, 2023
84bdf17
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jun 30, 2023
bd95faa
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 2, 2023
eceb8cf
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 5, 2023
58f21da
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 6, 2023
ed45602
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 17, 2023
7ca16d3
Update settingsGUI.cpp
discip Jul 17, 2023
0756568
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 18, 2023
ab3a427
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 20, 2023
b887d9c
Merge branch 'Ralim:dev' into finer-resolution-V-calibration
discip Jul 21, 2023
6c9e625
Merge branch 'Ralim:dev' into enhanced-V-calibration
discip Jul 24, 2023
3a2b516
Add files via upload
discip Jul 24, 2023
fad7f3f
Update settingsGUI.cpp
discip Jul 24, 2023
8a31f01
Update translations_definitions.json
discip Jul 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Translations/translation_BE.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Беларуская",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Каліброўка\nзроблена!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_BG.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Български",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_CS.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Český",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Kalibrace\ndokončena!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_DA.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Dansk",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_DE.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Deutsch",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Erfolgreich\nkalibriert!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_EL.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Greek",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Βαθμονόμηση\nολοκληρώθηκε!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_EN.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "English",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_ES.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Castellano",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "¡Calibracion\nlista!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_FI.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Suomi",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_FR.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Français",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Étalonnage\nterminé!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_HR.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Hrvatski",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Kalibracija\ndovršena!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_HU.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Magyar",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Kalibráció\nkész!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_IT.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Italiano",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibrazione\ncompletata!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_JA_JP.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "日本語",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration done!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_LT.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Lietuvių",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_NB.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Norsk bokmål",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_NL.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Nederlands",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_NL_BE.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Vlaams",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_PL.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Polski",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Kalibracja\nwykonana!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_PT.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Português",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibração\nefetuada!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_RO.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Română",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_RU.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Русский",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Калибровка\nзавершена!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_SK.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Slovenčina",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_SL.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Slovenščina",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_SR_CYRL.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Српски",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_SR_LATN.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Srpski",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_SV.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Svenska",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_TR.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Türkçe",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_UK.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Українська",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "КХС\nвідкалібровано!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_VI.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "Tieng Viet",
"tempUnitFahrenheit": false,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration\ndone!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_YUE_HK.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "廣東話 (香港)",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration done!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_ZH_CN.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "简体中文",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration done!"
},
"ResetOKMessage": {
Expand Down
2 changes: 1 addition & 1 deletion Translations/translation_ZH_TW.json
Expand Up @@ -3,7 +3,7 @@
"languageLocalName": "正體中文",
"tempUnitFahrenheit": true,
"messagesWarn": {
"CJCCalibrationDone": {
"CalibrationDone": {
"message": "Calibration done!"
},
"ResetOKMessage": {
Expand Down
4 changes: 2 additions & 2 deletions Translations/translations_definitions.json
@@ -1,7 +1,7 @@
{
"messagesWarn": [{
"id": "CJCCalibrationDone",
"description": "Confirmation message indicating CJC calibration is complete."
"id": "CalibrationDone",
"description": "Confirmation message indicating calibration is complete."
},
{
"id": "ResetOKMessage",
Expand Down
2 changes: 1 addition & 1 deletion source/Core/Inc/Translation.h
Expand Up @@ -107,7 +107,7 @@ enum class SettingsItemIndex : uint8_t {
};

struct TranslationIndexTable {
uint16_t CJCCalibrationDone;
uint16_t CalibrationDone;
uint16_t ResetOKMessage;
uint16_t SettingsResetMessage;
uint16_t NoAccelerometerMessage;
Expand Down
12 changes: 7 additions & 5 deletions source/Core/Src/settingsGUI.cpp
Expand Up @@ -884,29 +884,31 @@ static bool setCalibrateVIN(void) {
OLED::clearScreen();

for (;;) {
OLED::setCursor(0, 0);
OLED::setCursor(25, 0);
uint16_t voltage = getInputVoltageX10(getSettingValue(SettingsOptions::VoltageDiv), 0);
OLED::printNumber(voltage / 10, 2, FontStyle::LARGE);
OLED::print(LargeSymbolDot, FontStyle::LARGE);
OLED::printNumber(voltage % 10, 1, FontStyle::LARGE, false);
OLED::print(LargeSymbolVolts, FontStyle::LARGE);
OLED::setCursor(0, 8);
OLED::printNumber(getSettingValue(SettingsOptions::VoltageDiv), 3, FontStyle::SMALL);

switch (getButtonState()) {
case BUTTON_F_SHORT:
nextSettingValue(SettingsOptions::VoltageDiv);
prevSettingValue(SettingsOptions::VoltageDiv);
break;
case BUTTON_B_SHORT:
prevSettingValue(SettingsOptions::VoltageDiv);
nextSettingValue(SettingsOptions::VoltageDiv);
break;
case BUTTON_BOTH:
case BUTTON_F_LONG:
case BUTTON_B_LONG:
saveSettings();
OLED::clearScreen();
OLED::setCursor(0, 0);
OLED::printNumber(getSettingValue(SettingsOptions::VoltageDiv), 3, FontStyle::LARGE);
warnUser(translatedString(Tr->CalibrationDone), 3 * TICKS_SECOND);
OLED::refresh();
waitForButtonPressOrTimeout(1 * TICKS_SECOND);
waitForButtonPressOrTimeout(0.5 * TICKS_SECOND);
return false;
case BUTTON_NONE:
default:
Expand Down
2 changes: 1 addition & 1 deletion source/Core/Threads/OperatingModes/CJC.cpp
Expand Up @@ -30,7 +30,7 @@ void performCJCC(void) {
}
setSettingValue(SettingsOptions::CalibrationOffset, setoffset);
OLED::clearScreen();
warnUser(translatedString(Tr->CJCCalibrationDone), 3 * TICKS_SECOND);
warnUser(translatedString(Tr->CalibrationDone), 3 * TICKS_SECOND);
OLED::refresh();
// Preventing to repeat calibration at boot automatically (only one shot).
setSettingValue(SettingsOptions::CalibrateCJC, 0);
Expand Down