Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3 count filter for MHP30 acceleromter #1762

Merged
merged 8 commits into from Aug 4, 2023
Merged

Use 3 count filter for MHP30 acceleromter #1762

merged 8 commits into from Aug 4, 2023

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Jul 28, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

Requires it to trip 3 times in a row to fire. So really only knocking the unit over trips it off.
Also moves shutdown timer forwards when we shutdown timeout, and defaults shutdown timeout to being off (rather than 10 mins)
Should fix #1670 and also prevent nuisance trips.

@codingcatgirl Would be amazing if you could give this a spin when you get time 馃檱馃徏

Requires it to trip 3 times in a row to fire. So really only knocking the unit over trips it off.
@Ralim Ralim added this to the 2.22 milestone Aug 2, 2023
@Ralim Ralim merged commit 17b39de into dev Aug 4, 2023
30 checks passed
@Ralim Ralim deleted the MHP30-Filter-Accel branch August 4, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MHP30 can shutdown and not enter soldering mode until it is moved
2 participants