New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proper git SHA ID marking for builds during pull-requests #1772
Conversation
To be fully clear since this is very confusing for myself. Here is what I'm talking about:
Proper tagging never was so over-complicated for me before. Have no idea why it's not a github job to do it automagically for its users. P.S. It's not like I'm obsessed with that much. But since |
Now I consider this ready for review. No rush, just letting you know. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this, but also this is making the complexity of the hashing far more complex than it really ought to be. It's only there really as a means of checking if this was the release version or if this was a wip tag
What kind of change does this PR introduce?
Implement proper git SHA ID marking for builds during pull-requests.
What is the current behavior?
If a build has been produced on github CI after creating pull request, then git SHA ID doesn't equal to the latest git SHA ID in a user's branch.
What is the new behavior (if this is a feature change)?
Retrieve proper git SHA ID for marking builds during pull-requests using github CI environment variables through
push.yml
features.Other information:
As far as I understand (according to some pieces of information), here is what github does on builds for pull-requests:
git checkout COMMIT-ID_from_user_branch
git merge UPSTREAM
Therefore, getting COMMIT_ID using
git
command returns SHA ID for merge commit and not the latest commit to user branch. But with a couple of tricks there is a way to get original SHA ID. I tried to make as less changes as possible. Documentation updated as well. Debuggingprint
inmake_translation
will be removed once I double-check the output after creating this PR.