Update tagging for detached commit case & update docs #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Implement proper tagging for detached commit case.
What is the current behavior?
If the project tree in a detached commit case, then tagging logic goes for "Homebrew" build which is not correct.
What is the new behavior (if this is a feature change)?
Check if the tree is in a detached state and if it's the case then put SHA ID only instead of trying to get branch name.
Other information:
I hope this is last commit in the series considering all major possible cases for proper tagging so if there is any commit ID it doesn't lead to nowhere but allowing to ID the source tree used for a build.