Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowering min temp to 10C #623

Merged
merged 1 commit into from
May 28, 2020
Merged

Lowering min temp to 10C #623

merged 1 commit into from
May 28, 2020

Conversation

Firebie
Copy link

@Firebie Firebie commented May 5, 2020

Please try and fill out this template where possible, not all fields are required and can be removed.

  • Please check if the PR fulfills these requirements
  • The commit message makes sense
  • [] The changes have been tested locally
  • [] Are there any breaking changes
  • What kind of change does this PR introduce?
    (Bug fix, feature, docs update, ...)
    Lowering min temp from 50C to 10C

  • What is the current behavior?
    (You can also link to an open issue here)
    Question / Feature request: lowest min temp #620

  • What is the new behavior (if this is a feature change)?
    User can select 10C as min temp for soldering/sleep

  • Does this PR introduce a breaking change?
    (What changes might users need to make in their application due to this PR?)

  • Other information:

@Ralim
Copy link
Owner

Ralim commented May 22, 2020

Is this stable?
Originally the reason i limited the minimum to 50C was that the PID was unstable below that temperature when running off 24V input.

@Firebie
Copy link
Author

Firebie commented May 22, 2020

Checked 30C - works fine (although current weather is 28).
Checked 40C - works fine.
Power supply - 24V.

@Ralim
Copy link
Owner

Ralim commented May 28, 2020

Ah sorry, didn't merge this before i did the other one. Could you merge master in and then ill accept this in :)

@Firebie
Copy link
Author

Firebie commented May 28, 2020

I re-based against master

@Ralim Ralim merged commit 92ce612 into Ralim:master May 28, 2020
@Firebie Firebie deleted the LoweringMinTemp branch May 29, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants