Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all environment variables upper-cased? #138

Open
fourpastmidnight opened this issue May 9, 2023 · 0 comments · May be fixed by #140
Open

Make all environment variables upper-cased? #138

fourpastmidnight opened this issue May 9, 2023 · 0 comments · May be fixed by #140

Comments

@fourpastmidnight
Copy link
Contributor

I know we're dealing with PowerShell and that PowerShell is case-insensitive, but it is a common convention that environment variables always be UPPERCASED. Much more so in *nix environments. And given that this is actually creating environment variables which could be read outside of PowerShell, it would be better to follow this well-established convention.
fourpastmidnight added a commit to fourpastmidnight/BuildHelpers that referenced this issue Aug 9, 2023
@fourpastmidnight
feat(Set-BuildEnvironment): All environment variables are created wit…
aec7456 
…h UPPER-CASED names

Fixes RamblingCookieMonster#138
@fourpastmidnight fourpastmidnight linked a pull request Aug 9, 2023 that will close this issue
Open
fourpastmidnight added a commit to fourpastmidnight/BuildHelpers that referenced this issue Aug 11, 2023
@fourpastmidnight
feat(Set-BuildEnvironment): All environment variables are created wit…
c15cde4 
…h UPPER-CASED names

Fixes RamblingCookieMonster#138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Environment variable creation improvements fourpastmidnight/BuildHelpers
1 participant
@fourpastmidnight