Looks like version 5.8.1 pihole does not work correctly #2
Comments
|
Thanks for letting me know. I'm running this version: |
|
Looks like a bug on their end or they've deprecated something. Try yourself after confirming Pi Hole is enabled. Then check here: http://pihole_name_or_ip/admin/api.php?status&auth= if you have an auth token add it to the end of that line. Refresh that page after enabling/disabling pi hole in the UI. |
|
Looks like the status always shows as disabled for me too using the url. For some reason my device doesn’t switch it on/off either. I appreciate you looking into it, certainly seems that they deprecated something
… On Feb 6, 2022, at 8:56 AM, Ramias1 ***@***.***> wrote:
Looks like a bug on their end or they've deprecated something. Try yourself after confirming Pi Hole is enabled. Then check here:
http://pihole_name_or_ip/admin/api.php?status&auth=
if you have an auth token add it to the end of that line. Refresh that page after enabling/disabling pi hole in the UI.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
Pi hole team is tracking this issue here: pi-hole/web#2051 If this is critical you can edit line 132 of plugin.py and make the new line appear as: |
|
Perfect! I’ll give this a go!!
Thank you,
Daniel
… On Feb 6, 2022, at 6:40 PM, Ramias1 ***@***.***> wrote:
Pi hole team is tracking this issue here: pi-hole/web#2051
If this is critical you can edit line 132 of plugin.py and make the new line appear as:
url = u"http://" + dev.pluginProps["address"] + "/admin/api.php&auth=" + dev.pluginProps["password"]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
Probably my naivety, but I’m not sure where python.py file is located? Hopefully it’s not pulling from GitHub and compiling myself, as that’s a bit beyond me!
… On Feb 6, 2022, at 6:40 PM, Ramias1 ***@***.***> wrote:
url = u"http://" + dev.pluginProps["address"] + "/admin/api.php&auth=" + dev.pluginProps["password"]
|
|
I’m getting this in the console logs, over and over again:
Pi Hole DNS Controller Error Error in plugin execution runConcurrentThread:
Traceback (most recent call last):
File "plugin.py", line 163, in runConcurrentThread
File "plugin.py", line 140, in udpateStatus
UnboundLocalError: local variable 'response' referenced before assignment
Pi Hole DNS Controller Error plugin runConcurrentThread function returned or failed (will attempt again in 10 seconds)
Pi Hole DNS Controller Error Error in plugin execution runConcurrentThread:
… On Feb 7, 2022, at 8:04 AM, Ramias1 ***@***.***> wrote:
ok. try this: https://github.com/Ramias1/indigo-pi-hole/archive/refs/heads/statusfix.zip <https://github.com/Ramias1/indigo-pi-hole/archive/refs/heads/statusfix.zip>
—
Reply to this email directly, view it on GitHub <#2 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO66X5TVBRYFHCCTG5DJ3B3UZ7UQZANCNFSM5NVRHFVA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.
|
|
Do you use a webtoken password or is that blank? |
|
I use a webtoken password.
… On Feb 7, 2022, at 7:15 PM, Ramias1 ***@***.***> wrote:
Do you use a webtoken password or is that blank?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
Interesting. I do not use a web token password and it works for me — status, enable and disable. they must have had another change. That may be related to why you could not enable or disable when I could (even though status was broken due to that api change). let me check to see how far out they are from a new release. |
|
I really appreciate it! And that makes sense why you could still control it.
Thank you,
Daniel
… On Feb 7, 2022, at 7:48 PM, Ramias1 ***@***.***> wrote:
Interesting. I do not use a web token password and it works for me — status, enable and disable.
they must have had another change. That may be related to why you could not enable or disable when I could (even though status was broken due to that api change).
let me check to see how far out they are from a new release.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.
|
|
New release of PiHole appears to have fixed their status api. Please upgrade and try again. |
|
Hi @Ramias1, It appears that the issue of the warning message: Pi Hole DNS Controller Error plugin runConcurrentThread function returned or failed (will attempt again in 10 seconds) Has come back again or was never fully handled, is there a change to the code that can assign 'response' before being referenced in the plugin.py? Thank you, |
|
Hi @EagleDTW I've moved to Home Assistant (though I still love the awesome Indigo community) and no longer have an Indigo platform to reproduce this one. Does this only happen when you press the Update Status button in the GUI? If so, can you edit line 131 in the code from:
and reload and see what happens? |
|
Hi @Ramias1, This happens every 10 seconds filling up the event log on the screen. Not sure if this change will solve it but I'll try it out and report back. I've also moved to HA for the most part but still link back to indigo for some core features and the WAF of the homepages. Thank you, |
|
Hi @Ramias1, That actually didn't fix it! |
|
ok what happens if you do curl http://PIHOLE_IP/admin/api.php?auth=AUTHTOKEN ? |
|
I get no matches found response from terminal |
|
Hi @Ramias1, I escaped the zsh ? error and the response was []% I don't know if that is helpful or more confusing? Thank you, |
|
Is your Pi Hole the latest version? To eliminate any curl issues you could try that same string in like Chrome or Firefox. But looks like you are getting an empty response. |
|
Hi @Ramias1, Yes, pihole is 5.16.2 latest version and in the web browser with that command it is getting the raw result of [] - don't know what that means as I have the correct webpassword from both the pihole itself or the api password (same value) from within the pihole interface itself? |
|
it seems as though the variable response is being referenced too early in code is that possible or is the fact that it is empty reference throwing something off? |
|
Issue is the empty response. I redeployed my docker with a Webpassword variable (I normally run it with no password). I then saw this: It could be that the other API calls just work because they ignore the password entirely? I get a valid response with: Are you using your web password or an API key? (Settings/Api/Show API Token) If you do get a valid response with curl and an API key then change line 131 to: |
|
Hi @Ramias1, I did finally get an enabled response and changed the line to the mentioned code you have and it worked like a charm! Closing as solved! Thank you, |
|
Ok. If you want I can initialize response to “unavailable” which should prevent log spam but it may be harder to see if you have a connectivity or api issue in that case. |
|
Released version 2.1.1. It handles the new Pi Hole API. Should reduce log spam except for when Pi Hole is unavailable. |
|
Thank you, @Ramias1!Best regards,DanielOn May 13, 2023, at 5:49 PM, Ramias1 ***@***.***> wrote:
Released version 2.1.1. It handles the new Pi Hole API. Should reduce log spam except for when Pi Hole is unavailable.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi,
Looks like version 5.8.1 pihole does not work correctly to turn pihole active on and off.
Thank you,
Dan
The text was updated successfully, but these errors were encountered: