[Fix] - Kubeconfig merge needs user and cluster #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramilito
changed the title
Ramilito
commented
Feb 13, 2024
| #[derive(Default, Clone, PartialEq, Debug, Serialize, Deserialize)] | ||
| pub struct Users { | ||
| #[serde(default)] | ||
| pub user: HashMap<String, Value>, |
There was a problem hiding this comment.
Using hashmap here because we aren't interested in the structure and they can vary from providers (AWS,k3s,GKE)
|
Hi, thanks for adding me as a reviewer 😊 I'm quite busy this week but I'll have a look this Saturday! |
nicmr
approved these changes
Feb 20, 2024
|
Ive been running with this for a while and only noticed one issue, the kcd command doesn't permanently set it, I'm guessing it's because the merged files isn't known to kubectl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When merging and not using kubeconfig env variable, the resulting cached files don't have cluster and user in them.
This PR adds those so they can be more complete.
Results:
Fixes # (issue)
#46 Fixes part of this
Type of change
How Has This Been Tested?
Tested locally by using it for a while