Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Versions #3

Closed
chrisblossom opened this issue May 17, 2016 · 3 comments
Closed

React Versions #3

chrisblossom opened this issue May 17, 2016 · 3 comments

Comments

@chrisblossom
Copy link
Contributor

Is this only for React v15 or can it be used with v0.14? If so, would you accept a PR to move React to the peer deps as follows:

...
  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.0",
    "react-addons-perf": "^0.14.0 || ^15.0.0"
...
@RamonGebben
Copy link
Owner

@chrisblossom sure that would be acceptable. However I'm not familiar with the || operator in the version. Could you link some documentation on this subject?

As far as I know the measurements should still work for 0.14.x after the fix for #2.

@chrisblossom
Copy link
Contributor Author

This is how reactjs/react-redux/package.json does it. https://docs.npmjs.com/misc/semver explains it in detail.

@RamonGebben
Copy link
Owner

Sure make it work. Do you want to send a pull request to close the issue. Or shall I pick it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants