Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Picture in Picture #206

Closed
Ichisich opened this issue Jun 27, 2022 · 6 comments
Closed

Firefox Picture in Picture #206

Ichisich opened this issue Jun 27, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@Ichisich
Copy link

Ichisich commented Jun 27, 2022

Firefox's picture in picture (pip) can generate an external window for videos on almost every website.
The generated window is categorized completely as title bar (WM_NCHITTEST=2)

Since title bar actions are implemented and can create such mismatches, an additional black list would be advisable.

@Ichisich
Copy link
Author

Ichisich commented Jun 27, 2022

I tested MMBLower=Bild-im-Bild|MozillaDialogClass and it worked.

The MMBLower Blacklist seems to be already what I asked for.
I would perhaps add Firefox's pip as a default entry in the next release.

@RamonUnch
Copy link
Owner

RamonUnch commented Jun 27, 2022

I guess it makes sense, however the title: Bild-im-Bild seems language based, so if we want to add *|MozillaDialogClass we need to check that it will not disturb normal Firefox windows.
The main window is *|MozillaWindowClass and I think that the *|MozillaDialogClass is only used in the Help->about dialog which is not very important.
So I will add *|MozillaDialogClass` and see if I see some problems.

@RamonUnch
Copy link
Owner

So now titlebar the blacklist will be:

MMBLower=*|CASCADIA_HOSTING_WINDOW_CLASS,*|SDL_app,*|MozillaDialogClass

@Ichisich
Copy link
Author

Unfortunate, that there is no language agnostic solution.
I will use *|MozillaDialogClass for some days and report if something becomes iffy.

@RamonUnch RamonUnch added the bug Something isn't working label Jul 14, 2022
@RamonUnch
Copy link
Owner

From my experience it seems good.

@Ichisich
Copy link
Author

Ichisich commented Aug 2, 2022

Can confirm, the only other collateral damage besides Firefox's about box is Thunderbird's about box.
Both are obscure and not really essential in daily use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants