Update targets and fix issue with contexts #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport lib dependency
…Activity holding onboarding is light (or vice versa). Also removed hardcoding title and text in layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was using the library and found out that on some devices (in particular with Android 5-5.1.1 there are some issues reading the context.
The OnBoardingEngine is using the ApplicationContext instead of the ActivityContext in which it is added. This issue is subdule to find and see. You have it if, for example have a main theme which is Dark, and the activity holding the onboarding is a Light theme. If you have so, the texts in the carousel is white, even if in a light theme!
This pull request (in particular the commit
cd500e6 that uses the ActivityContext instead.