Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded widget fix #2168

Merged
merged 2 commits into from Jul 2, 2020
Merged

Embedded widget fix #2168

merged 2 commits into from Jul 2, 2020

Conversation

Wevah
Copy link
Member

@Wevah Wevah commented Jul 2, 2020

Fixes #2166.

These were fixed on mac-release in #1833, but they never made it to master.

Wevah added 2 commits July 2, 2020 04:32
@Wevah
Only wrap iframes that don't specify their own height
dc57981 
(master version of e183a54)
@Wevah
Don't force iframe height to auto
014724e 
Prevents truncating of YouTube embeds without needing a wrapper div.

(master version of 82f8951).

This also sets max-width: 100%; on video instead of width: 100% !important;.
@vincode-io vincode-io merged commit f9805b6 into Ranchero-Software:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twitter embeds cut off
2 participants
@Wevah @vincode-io