-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.10 Installer is FUBAR! #979
Comments
What version of Windows are you using? What happens exactly when you try to run the installer? Do you see any window open at all? |
I'm using Windows 10.
[image: image.png]
The vidcoder splash screen pops up.
It says installing with a progress bar.
[image: image.png]
The bar seems to go all the way to the end.
But there's nothing after that.
No icon on the desktop. Nothing is found when i search for vidcoder to run
it.
…On Sun, Feb 13, 2022 at 5:18 PM David Rickard ***@***.***> wrote:
What version of Windows are you using? What happens exactly when you try
to run the installer? Do you see any window open at all?
—
Reply to this email directly, view it on GitHub
<#979 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOBEZ7YJSY7XCIQYKY4SKNTU3A36BANCNFSM5OJ3N3AQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
same issue here. Fully updated Windows 10. The installer runs, then the program wont start - nothing in task manager either. Completely uninstalled and removed registry traces doesn't change the issue. |
Okay can you open a command prompt/powershell/windows terminal to the VidCoder.Stable directory and try these commands?
Let me know if any shortcuts get created when running it manually, or if anything shows up in the command line output. https://github.com/clowd/Clowd.Squirrel/blob/develop/docs/using/debugging-installs.md |
Oh also check |
are you sure that syntax is correct? It just prints out the help and I have to control-C to get a command line back.
|
and there's no folder in \roaming for vidcoder at all, so no log file |
Okay that's good to know as well. That means that it never ran the "on install" actions for VidCoder. It got hung up in some earlier step. As for the command line, I actually had not tried it. But I did find another place to look for logs: |
From the log on my system when installing 7.10 (in 2022-02-14 09:16:50.6481 [ERROR] - ApplyReleasesImpl: Couldn't run Squirrel hook, continuing: C:\Users\Caelan\AppData\Local\VidCoder.Stable\app-7.10.0\VidCoder.exe: System.OperationCanceledException: The operation was canceled.
at System.Threading.CancellationToken.ThrowOperationCanceledException()
at Squirrel.Utility.<>c__DisplayClass18_0.<InvokeProcessUnsafeAsync>b__0() in ./Internal/Utility.cs:line 295
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.<>c.<.cctor>b__271_0(Object )
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread , ExecutionContext , ContextCallback , Object )
--- End of stack trace from previous location ---
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread , ExecutionContext , ContextCallback , Object )
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& , Thread )
--- End of stack trace from previous location ---
at Squirrel.Utility.InvokeProcessUnsafeAsync(ProcessStartInfo psi, CancellationToken ct) in ./Internal/Utility.cs:line 288
at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass10_0.<<invokePostInstall>b__0>d.MoveNext() in ./UpdateManager.ApplyReleases.cs:line 408 This means that the Squirrel install was successful, but the hooks failed to run meaning shortcuts did not get created. Additionally, running the command I should note that the only thing that appears to have failed is the shortcut creation. The files were extracted successfully, uninstall entries were created and normal uninstallation was possible through Apps & Features. Additionally, running |
Same here. But it is not just the installation. Downloaded the .zip and extracted it to a folder. Ran it and vicoder.exe shows up in task manager... and unloads without stating any error. Very "stable". 7.8 works, 7.9 and 7.10 do not: Faulting application name: VidCoder.exe, version: 7.10.0.0, time stamp: 0x61e1d8d9 Faulting application name: VidCoder.exe, version: 7.9.0.0, time stamp: 0x61e1d8d9 |
here's my log if it helps
|
Thanks for the logs. This doesn't reproduce for me when I run the .exe or when I run via command line via Here is my code to run on install:
It sounds like the uninstaller registry entries were created successfully, but from @starkebn 's screenshot, the icons didn't get copied to the root folder. So if this is hanging, it must be hanging on the @caesay did you see anything in |
@RandomEngy The log folder is not created. Running the program with or without arguments fails to create the logs folder (I checked roaming and local appdata), nor does it show any window. I suspected the process is failing to start due to a missing dependency or hanging somewhere before the Squirrel hooks even run. Looking at event viewer after trying to launch VidCoder.exe, there are several errors - but the one of primary interest is probably this: Application: VidCoder.exe
CoreCLR Version: 6.0.121.56705
.NET Version: 6.0.1
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.FileLoadException: Could not load file or assembly 'PresentationFramework, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'PresentationFramework, Version=6.0.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' Notably, the reference is looking for 6.0.2 and I only have 6.0.1 installed. My impression was that these .net patches were incremental and compatible patches - eg security updates, and not feature/breaking changes requiring reference updates, so I wouldn't have expected an error like this. Installing the x64 desktop runtime 6.0.2 manually solved the error and VidCoder.exe was able to start. Looking at the dotnet manifest in ildasm (https://bin.caesay.com/kikezurisu.txt) it seems WPF and WinForms are requiring the 6.0.2 assemblies, but nothing else seems to. Binding redirects are not supported in dotnet core, so I'm not even sure if you could patch this at runtime to use 6.0.1 etc. The current Squirrel logic when checking for installed runtimes during setup will accept any version of 6.0.* as valid when installing. I suppose the logic could be to always install the latest dotnet runtime if the currently installed version is not the latest, but that feels less than optimal. Thoughts? The alternative, I suppose, is requiring people to be more specific about what net version their app uses (eg |
Same here, after manually installing the x64 desktop runtime 6.0.2 now version 7.10 works. |
Good catch! I'd be fine with specifying a specific version to target. That would negate the need to embed more tools in the installer to go snooping around DLLs. |
7.11 is loading fine |
Installing 7.11.exe doesn't work when trying to update from version 6.46 |
@Neipas09 When you say "doesn't work", what are you seeing? Is it getting stuck? Closing? Do you see an error message? Did you try manually installing the .NET x64 Desktop Runtime 6.0.2? |
After installing .net 6.0.2 I was able to install 6.46, follow the update prompts and get upgraded to 7.10 (and then subsequently 7.11 right afterwards). The old application got cleaned up successfully and the new version was launched. Presumably for anyone without 6.0.2, the old version of vidcoder will not be removed properly. I'm working on something for Squirrel to allow a min dotnet version to be specified when building your installer, I should be able to publish an update for this tomorrow or the day after. If you're looking for a fix faster than that, you could re-build VidCoder against 6.0.0 instead of 6.0.2. |
I tried installing 7.11 after that, and it puts files into But when i try to run the Vidcoder.exe nothing opens. |
I tried this, and could never get 7.10 to run. |
You need to install the .NET 6.0.2 Desktop Runtime. |
ooooh.... :-/ |
caesay is in this thread and works on the installer framework that VidCoder is switching to. It's supposed to install the appropriate version of the .NET framework automatically but currently there is an issue where it doesn't work in all circumstances. He's working on a fix in the next few days and I'll pick it up for VidCoder after it's ready. |
@RandomEngy Fixes for this have been released in 2.8.1-pre. I have used your application to test this (hope you don't mind) as well as one of my own. Please review the comments in the release notes and the attached issue for more details. |
I've released VidCoder 7.12 which uses 2.8.1-pre and is packed using |
@RandomEngy Just wanted to add, it turns out this is actually a bug in the 6.0.200 SDK (rather than an issue with the approach we had in Squirrel). Can see here dotnet/wpf#6109 and dotnet/winforms#6663. I think I will keep the changes made to Squirrel, because I believe they were good changes to have anyway (adding a warning to detect this when it happens, and allowing more specificity when selecting a dotnet runtime)... However, in the future, when this issue with the SDK is resolved (or by employing the workaround mentioned at one of those links) you can revert back to just using |
Thanks for the update. I'll change back to net6-x64 when they fix the issue. |
Problem Description
Unable to install and run Vidcoder with 7.10 installer .exe
Tried downloading .exe and using chocolatey. Fails no matter what.
What version of VidCoder are you running?
7.10
Encode Log
No response
The text was updated successfully, but these errors were encountered: