Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom File Systems of VSCode #309

Open
gbrueckl opened this issue Sep 6, 2022 · 5 comments
Open

Support for custom File Systems of VSCode #309

gbrueckl opened this issue Sep 6, 2022 · 5 comments

Comments

@gbrueckl
Copy link

gbrueckl commented Sep 6, 2022

It seems that the data preview currently does not support custom file systems created for VSCode using the (https://code.visualstudio.com/api/extension-guides/virtual-documents, https://github.com/microsoft/vscode-extension-samples/blob/main/fsprovider-sample/README.md)

So I have a custom file system and a file stored on it (e.g. foo://myfolder/myfile.csv). Everything works fine in VSCode itself (opening it from explorer, previewing, etc.) but the extensions does not seem to be able to load that file complaining about that /myfolder/myfile.csv does not exists

Is this supposed to work?
if not, any plans to add this feature?

thanks in advance,
-gerhard

@RandomFractals
Copy link
Owner

RandomFractals commented Sep 6, 2022

That is correct. Data preview predates workspace.fs and newer apis vscode team added later for reading files in vscode and web editor version of vscode.

Could you provide a specific use case where you use CSV data files with a custom file scheme? Also, see #298.

For the time being only local data files and remote files served over https:// are supported in data preview.

Also, worth noting that data preview dependencies are very outdated, and will be updated soon either in this extension or the new tabular data viewer I am working on.

@gbrueckl
Copy link
Author

gbrueckl commented Sep 6, 2022

so the use-case is very similar to what was already discussed in in #298 - it would also be my long-time goal to have everything run also as a web-extension.
However, custom file system can also be very beneficial in desktop mode.

So in our extension for Databricks (a big data processing engine in the cloud) the results are stored in Databricks` internal file system called DBFS. I created a custom file system which allows me to "mount" the DBFS into the VSCode explorer https://raw.githubusercontent.com/paiqo/Databricks-VSCode/master/images/FileSystemIntegration.jpg

You would usually do some processing of data on Databricks and view the result files (usually CSV, Parquet, etc.) with a proper data viewer like yours. It would really come in handy to inspect the files from within VSCode directly as accessing them otherwise can be cumbersome

I am also currently in the progress of rewriting everything to workspace.vs as I think it is definitely the way to go for the future and it is actually super powerful!

@RandomFractals
Copy link
Owner

Sure, those are good use cases.

I am still debating if they will be supported in data preview, or the new tabular data viewer I'll be working on in the remaining months this year.

Relevant tickets in that repo and alpha v. I just made public again:

RandomFractals/tabular-data-viewer#114

RandomFractals/tabular-data-viewer#46

More info about that under our TablularDataViewer hashtag on twitter ...

https://twitter.com/hashtag/TabularDataViewer?src=hashtag_click

@gbrueckl
Copy link
Author

gbrueckl commented Sep 6, 2022 via email

@RandomFractals
Copy link
Owner

RandomFractals commented Sep 6, 2022

@gbrueckl I have not decided on that part yet, but if you want to try the latest version of perspective viewer with large csv data files for now, that's the extension you should try.

I will be adding other Pro sponsors only features to that extension in the months to come. Data preview updates are on hold till I get better sense of how that new viewer is shaping up with embedded analytics db for large data files, streaming data, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants