Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Data Table Renderers to work on github.dev and in the web version of vscode IDE #122

Closed
RandomFractals opened this issue Apr 4, 2022 · 4 comments
Closed

Enable Data Table Renderers to work on github.dev and in the web version of vscode IDE #122

RandomFractals opened this issue Apr 4, 2022 · 4 comments
Labels
feature New feature

Comments

@RandomFractals
Copy link
Owner

RandomFractals commented Apr 4, 2022 •
edited
Loading

see docs: https://code.visualstudio.com/api/extension-guides/web-extensions

& Microsoft VSCode Notebook Renderers that currently work in a browser:

https://github.com/microsoft/vscode-notebook-renderers

Current Pyolite notebook raw JSON data output due to lack of rich data table renderers in that vscode IDE context:

pyolite-nb-json-output
@RandomFractals RandomFractals added the feature New feature label Apr 4, 2022
RandomFractals added a commit that referenced this issue Apr 4, 2022
@RandomFractals
add browser entry point to use data table renderers in web versions o…
e02b78d 
…f vscode (#122)
@RandomFractals
Copy link
Owner Author

Looks like this works after adding browser entry point to package.json & using https://github.com/microsoft/vscode-test-web to test data table renderers extension locally:

flat-data-grid-in-browser

RandomFractals added a commit that referenced this issue Apr 5, 2022
@RandomFractals
use Uri.joinPath to construct built-in notebook example Uri (#122)
626994c 
in order to web-enable this extenion
RandomFractals added a commit that referenced this issue Apr 8, 2022
@RandomFractals
bundle extension for vscode web editor (#122)
c074d75 
- add webpack.extension.config.js
- add build renderer and extension scripts
- add test:web script
...
@RandomFractals
Copy link
Owner Author

ok. that fixes web extension loading ...

show-running-extensions-web

RandomFractals added a commit that referenced this issue Apr 8, 2022
@RandomFractals
log notebook example uri to debug notebooks loading in web editor (#122)
c234bcd
@RandomFractals
Copy link
Owner Author

RandomFractals commented Apr 8, 2022 •
edited
Loading

confirmed that those changes work in Code Spaces:

image

However, those sample notebook files are downloaded in vscode web editor on https://github.dev and https://vscode.dev because the constructed path of example notebooks is an http based Url, not a file in web IDE. So, vscode.open we use to load those example notebooks results in a file download and doesn't open it in vscode editor tab.

RandomFractals added a commit that referenced this issue Apr 10, 2022
@RandomFractals
add data renderers in web editor info and example pic to features lis…
62f3146 
…t in docs (#122)
RandomFractals added a commit that referenced this issue Apr 10, 2022
@RandomFractals
add web ext. feature to changelog for v1.10.0 release (#122)
fd576d3
@RandomFractals
Copy link
Owner Author

released in v1.10: https://github.com/RandomFractals/vscode-data-table/releases/tag/v1.10.0

@RandomFractals RandomFractals mentioned this issue Apr 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RandomFractals