Styling #4
Merged
Styling #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Database access
- changed data table back from CSS grid to table - adjusted tags and structure - the name of the person now is a heading (caption) not a table row - added styling - added Javascript to only show a preview of the content if it is too large
- linked people.css to people.php (in head) - added comment regarding `themecolor`
fixed commit
- themecolor now is determined automatically, though it can be manually overridden - spacing was automatically adjusted
__DIR__ returns the directory of the file
reformatting, relinking, added new rows
Non-Binary now supported
added 2 commits
April 10, 2022 22:46
some minor fixes
added 2 commits
April 10, 2022 23:32
added fonts and Licenses
eintyp
previously approved these changes
Apr 10, 2022
config.php
Outdated
| 'password' => "password", | ||
| 'DBname' => "worldDB", | ||
| ); | ||
| ?> |
scripts/connection.php
Outdated
| die ( "Connection failed: " . $conn->connect_error ); | ||
| } | ||
| return $conn; | ||
| ?> |
| <?php | ||
| $config = require ($_SERVER['DOCUMENT_ROOT'] . "../config.php"); | ||
| // Create connection | ||
| $conn = new mysqli ( $config ['servername'], $config ['username'], $config ['password'], $config ['DBname'] ); |
There was a problem hiding this comment.
consider wrapping the whole thing in a class and making the connection static
Co-authored-by: Ein Typ <34921967+eintyp@users.noreply.github.com>
eintyp
reviewed
Apr 10, 2022
people.php
Outdated
| <?php | ||
| // Main color of color sheme (appearance image) and version with alpha = 0 | ||
| if (file_exists($imgpath)) { | ||
| include_once (__DIR__ . "/scripts/themecolor.php"); |
There was a problem hiding this comment.
Suggested change
| include_once (__DIR__ . "/scripts/themecolor.php"); | |
| require_once (__DIR__ . "/scripts/themecolor.php"); |
There was a problem hiding this comment.
the script is not critical for operation
Co-Authored-By: Ein Typ <34921967+eintyp@users.noreply.github.com>
better than if else chain Co-authored-by: Ein Typ <34921967+eintyp@users.noreply.github.com>
Co-Authored-By: Ein Typ <34921967+eintyp@users.noreply.github.com>
to match php convention
Co-Authored-By: Ein Typ <34921967+eintyp@users.noreply.github.com>
Co-authored-by: Ein Typ <34921967+eintyp@users.noreply.github.com>
This was referenced Apr 11, 2022
Co-authored-by: Ein Typ <34921967+eintyp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some style changes